From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/print: require struct drm_device for drm_err() and friends
Date: Tue, 25 Feb 2025 17:52:56 +0100 [thread overview]
Message-ID: <20250225175256.70b616a5@booty> (raw)
In-Reply-To: <dfe6e774883e6ef93cfaa2b6fe92b804061ab9d9.1737644530.git.jani.nikula@intel.com>
On Thu, 23 Jan 2025 17:09:12 +0200
Jani Nikula <jani.nikula@intel.com> wrote:
> The expectation is that the struct drm_device based logging helpers get
> passed an actual struct drm_device pointer rather than some random
> struct pointer where you can dereference the ->dev member.
>
> Add a static inline helper to convert struct drm_device to struct
> device, with the main benefit being the type checking of the macro
> argument.
>
> As a side effect, this also reduces macro argument double references.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-02-25 17:08 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 15:09 [PATCH 0/5] drm: strict type checking for drm_device based logging helpers Jani Nikula
2025-01-23 15:09 ` [PATCH 1/5] drm/mipi-dsi: stop passing non struct drm_device to drm_err() and friends Jani Nikula
2025-02-25 16:52 ` Luca Ceresoli
2025-01-23 15:09 ` [PATCH 2/5] drm/rockchip: " Jani Nikula
2025-01-23 15:09 ` Jani Nikula
2025-01-24 9:53 ` Andy Yan
2025-01-24 9:53 ` Andy Yan
2025-01-24 11:43 ` Jani Nikula
2025-01-24 11:43 ` Jani Nikula
2025-01-25 3:53 ` Andy Yan
2025-01-25 3:53 ` Andy Yan
2025-02-25 19:34 ` Jani Nikula
2025-02-25 19:34 ` Jani Nikula
2025-02-26 8:33 ` [PATCH " Thomas Zimmermann
2025-02-26 8:33 ` Thomas Zimmermann
2025-02-26 10:36 ` Andy Yan
2025-02-26 10:36 ` Andy Yan
2025-02-26 11:33 ` Jani Nikula
2025-02-26 11:33 ` Jani Nikula
2025-02-24 14:47 ` Louis Chauvet
2025-02-24 14:47 ` Louis Chauvet
2025-01-23 15:09 ` [PATCH 3/5] drm/sched: " Jani Nikula
2025-01-23 19:54 ` Simona Vetter
2025-01-24 11:46 ` Jani Nikula
2025-01-27 10:11 ` Philipp Stanner
2025-02-24 15:29 ` Tvrtko Ursulin
2025-02-24 14:48 ` Louis Chauvet
2025-01-23 15:09 ` [PATCH 4/5] drm/print: Include drm_device.h Jani Nikula
2025-01-23 15:14 ` Jani Nikula
2025-01-23 16:14 ` Gustavo Sousa
2025-01-24 11:50 ` Jani Nikula
2025-01-24 12:21 ` Gustavo Sousa
2025-01-24 12:55 ` Simona Vetter
2025-01-23 15:09 ` [PATCH 5/5] drm/print: require struct drm_device for drm_err() and friends Jani Nikula
2025-02-24 14:48 ` Louis Chauvet
2025-02-25 16:52 ` Luca Ceresoli [this message]
2025-05-15 20:18 ` Bill Wendling
2025-05-15 23:52 ` Bill Wendling
2025-05-16 9:48 ` Jani Nikula
2025-05-16 20:41 ` Bill Wendling
2025-01-23 16:05 ` ✗ Fi.CI.SPARSE: warning for drm: strict type checking for drm_device based logging helpers Patchwork
2025-01-23 16:13 ` ✓ i915.CI.BAT: success " Patchwork
2025-01-24 8:26 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-04 15:07 ` [PATCH 0/5] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225175256.70b616a5@booty \
--to=luca.ceresoli@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.