From: Al Viro <viro@zeniv.linux.org.uk>
To: Pranjal Prasad <prasadpranjal213@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Improved hfsplus in the kernel
Date: Tue, 25 Feb 2025 20:59:41 +0000 [thread overview]
Message-ID: <20250225205941.GA2023217@ZenIV> (raw)
In-Reply-To: <378405f0-f3ff-47b0-9596-a6ff56fb7c91@gmail.com>
On Wed, Feb 26, 2025 at 02:00:36AM +0530, Pranjal Prasad wrote:
> Hi,
>
> Please find attached the patch to improve the HFS+ filesystem support in the
> kernel. I have not done much work, but as I require HFS, HFS+, and APFS in
> Linux, I decided to maintain it. Please allow me to be the maintainer of HFS
> and HFS+ in the kernel.
Umm... "Improved" is not a description - it's marketdroidese.
And comments are supposed to help understanding why we are doing
something, not retelling what's being done in every line.
Being more verbose is no virtue - not when it adds no information.
What's more worrying, though... are there actual changes in
that pile of added comments? Your "improved and added comments"
would seem to imply that these had been two distinct things,
so it sounds like there are actual modifications involved.
In such case you really should separate those rather than
burying them.
And this "every line must come with a comment, no matter how useful it is"
is a habit best unlearnt. I realize that a bunch of places teach that,
but it's a really, really bad idea.
prev parent reply other threads:[~2025-02-25 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 20:30 [PATCH] Improved hfsplus in the kernel Pranjal Prasad
2025-02-25 20:59 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225205941.GA2023217@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=prasadpranjal213@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.