From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EE23216E32 for ; Wed, 26 Feb 2025 02:14:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536075; cv=none; b=Y8Qu7mnwaINlkEcy6Mww8xWtXeFqvhudJ+Gr9xg6XDbCXr2SgD7fMw/7wZHJ8QdZcDimHMWhaMEsqY1aeZZYE/+1E04L9KtWuJ6JEee9lp1Jf/zUd+ad9XqUi4kUgtWLWcjJ/qa4m1U4uNSnt/nwspB03mFXq+EjL+X2qtEV8eo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536075; c=relaxed/simple; bh=c/QX+Vma1zL8Fgugjg6vMCL9Gb86omczzcdXPwNmqWY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OrzNK6b135Ba/YOU/g/M1yiKayX3ctIWDqBcbQRJxAS7aWsMp6X8zFcsP6x24vJoF6PITvmq/8DfvEM+SLlzK+0nJq8GDQF3/CfQXG7+lF6ooyr6aweKWeh+GqxgCzzdq8/pA2kK1PB0z82hthwXX9vhU1yRKsu+I5CiQSyFtGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=moazGQ8d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="moazGQ8d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33B66C4CEDD; Wed, 26 Feb 2025 02:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740536075; bh=c/QX+Vma1zL8Fgugjg6vMCL9Gb86omczzcdXPwNmqWY=; h=From:To:Cc:Subject:Date:Reply-to:From; b=moazGQ8divrMNaIrYMefCswPPkIPJaZe7pHa9F88UCCkXFzieyNoXICGwe7IpIiVn XkCek6KCXMh4bba2npja+c1sUcOvNNE3VSkrYcBHCPX1Ojc80bO2qAkbAb3XtB8kv0 vBHTcc2JQfYMIj50Yp2ITudLYBQjRTiYGRaLbyqo= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-49458: drm/msm: don't free the IRQ if it was not requested Date: Wed, 26 Feb 2025 03:12:12 +0100 Message-ID: <2025022600-CVE-2022-49458-46ef@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=5449; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=c/QX+Vma1zL8Fgugjg6vMCL9Gb86omczzcdXPwNmqWY=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7yn+4J2/aWvtcfLax/5zflnu9T/W9lO9UWdJuX1z3l VOb1/hpRywLgyATg6yYIsuXbTxH91ccUvQytD0NM4eVCWQIAxenAExkpT3DPM19j+V9NNuEHtz8 F3qcT/48g91XXoYFFyqWnzGbtvnlSf7bTmc8noS19P4MAgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: drm/msm: don't free the IRQ if it was not requested As msm_drm_uninit() is called from the msm_drm_init() error path, additional care should be necessary as not to call the free_irq() for the IRQ that was not requested before (because an error occured earlier than the request_irq() call). This fixed the issue reported with the following backtrace: [ 8.571329] Trying to free already-free IRQ 187 [ 8.571339] WARNING: CPU: 0 PID: 76 at kernel/irq/manage.c:1895 free_irq+0x1e0/0x35c [ 8.588746] Modules linked in: pmic_glink pdr_interface fastrpc qrtr_smd snd_soc_hdmi_codec msm fsa4480 gpu_sched drm_dp_aux_bus qrtr i2c_qcom_geni crct10dif_ce qcom_stats qcom_q6v5_pas drm_display_helper gpi qcom_pil_info drm_kms_helper qcom_q6v5 qcom_sysmon qcom_common qcom_glink_smem qcom_rng mdt_loader qmi_helpers phy_qcom_qmp ufs_qcom typec qnoc_sm8350 socinfo rmtfs_mem fuse drm ipv6 [ 8.624154] CPU: 0 PID: 76 Comm: kworker/u16:2 Not tainted 5.18.0-rc5-next-20220506-00033-g6cee8cab6089-dirty #419 [ 8.624161] Hardware name: Qualcomm Technologies, Inc. SM8350 HDK (DT) [ 8.641496] Workqueue: events_unbound deferred_probe_work_func [ 8.647510] pstate: 604000c5 (nZCv daIF +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 8.654681] pc : free_irq+0x1e0/0x35c [ 8.658454] lr : free_irq+0x1e0/0x35c [ 8.662228] sp : ffff800008ab3950 [ 8.665642] x29: ffff800008ab3950 x28: 0000000000000000 x27: ffff16350f56a700 [ 8.672994] x26: ffff1635025df080 x25: ffff16350251badc x24: ffff16350251bb90 [ 8.680343] x23: 0000000000000000 x22: 00000000000000bb x21: ffff16350e8f9800 [ 8.687690] x20: ffff16350251ba00 x19: ffff16350cbd5880 x18: ffffffffffffffff [ 8.695039] x17: 0000000000000000 x16: ffffa2dd12179434 x15: ffffa2dd1431d02d [ 8.702391] x14: 0000000000000000 x13: ffffa2dd1431d028 x12: 662d79646165726c [ 8.709740] x11: ffffa2dd13fd2438 x10: 000000000000000a x9 : 00000000000000bb [ 8.717111] x8 : ffffa2dd13fd23f0 x7 : ffff800008ab3750 x6 : 00000000fffff202 [ 8.724487] x5 : ffff16377e870a18 x4 : 00000000fffff202 x3 : ffff735a6ae1b000 [ 8.731851] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff1635015f8000 [ 8.739217] Call trace: [ 8.741755] free_irq+0x1e0/0x35c [ 8.745198] msm_drm_uninit.isra.0+0x14c/0x294 [msm] [ 8.750548] msm_drm_bind+0x28c/0x5d0 [msm] [ 8.755081] try_to_bring_up_aggregate_device+0x164/0x1d0 [ 8.760657] __component_add+0xa0/0x170 [ 8.764626] component_add+0x14/0x20 [ 8.768337] dp_display_probe+0x2a4/0x464 [msm] [ 8.773242] platform_probe+0x68/0xe0 [ 8.777043] really_probe.part.0+0x9c/0x28c [ 8.781368] __driver_probe_device+0x98/0x144 [ 8.785871] driver_probe_device+0x40/0x140 [ 8.790191] __device_attach_driver+0xb4/0x120 [ 8.794788] bus_for_each_drv+0x78/0xd0 [ 8.798751] __device_attach+0xdc/0x184 [ 8.802713] device_initial_probe+0x14/0x20 [ 8.807031] bus_probe_device+0x9c/0xa4 [ 8.810991] deferred_probe_work_func+0x88/0xc0 [ 8.815667] process_one_work+0x1d0/0x320 [ 8.819809] worker_thread+0x14c/0x444 [ 8.823688] kthread+0x10c/0x110 [ 8.827036] ret_from_fork+0x10/0x20 Patchwork: https://patchwork.freedesktop.org/patch/485422/ The Linux kernel CVE team has assigned CVE-2022-49458 to this issue. Affected and fixed versions =========================== Issue introduced in 5.15 with commit f026e431cf861197dc03217d1920b38b80b31dd9 and fixed in 5.15.46 with commit beb81c13d020ceb7f8693e65464162e5f249218e Issue introduced in 5.15 with commit f026e431cf861197dc03217d1920b38b80b31dd9 and fixed in 5.17.14 with commit b288ec4439c1dad304c1862bf6b0be78d9b1b2b2 Issue introduced in 5.15 with commit f026e431cf861197dc03217d1920b38b80b31dd9 and fixed in 5.18.3 with commit 59023c4fb1ab3de0fa001681650f662c253c7fd7 Issue introduced in 5.15 with commit f026e431cf861197dc03217d1920b38b80b31dd9 and fixed in 5.19 with commit 577e2a9dfc8fba7938aaf75db63fae7e328cc3cb Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-49458 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/gpu/drm/msm/msm_drv.c drivers/gpu/drm/msm/msm_kms.h Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/beb81c13d020ceb7f8693e65464162e5f249218e https://git.kernel.org/stable/c/b288ec4439c1dad304c1862bf6b0be78d9b1b2b2 https://git.kernel.org/stable/c/59023c4fb1ab3de0fa001681650f662c253c7fd7 https://git.kernel.org/stable/c/577e2a9dfc8fba7938aaf75db63fae7e328cc3cb