From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ADEB17A31B for ; Thu, 27 Feb 2025 02:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740622407; cv=none; b=Ho20vwICkUDbuV3hxietQnfEheWREePHVoFw29U8rUtIfhKD2DwlsIabcbCSl5k3CEL01cGplhQZj6Gm1Ef79JwKsIU1LnSUw51YAF3TH6iGjnfYKvMQqdMW+bFz7mgcJd4+WHyQ3qGfvRg8IkJrBQdsz4RD7QkNoWM4fear/go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740622407; c=relaxed/simple; bh=ixjd9VBWy1avK4jR2CXtqT46XYDYtKxWZAHFA+554Cw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CgCIUEmEHqzrqf7Ex0hxO6noQStPkuxd9WN52tXaXB+sxsge1wMQTI+XKwpPkToUyvMQdwSSWaI509hNg7373MnY0VmdvjsVV/8exr4jpqvv+D2E69xmEl5+G2+QIGk2KghQ/2KWr4rv5KwPL0/IWuV1VR3MWRFCNdy+nPlYOeE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=CFFt9n/D; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="CFFt9n/D" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2AD9C4CED6; Thu, 27 Feb 2025 02:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740622407; bh=ixjd9VBWy1avK4jR2CXtqT46XYDYtKxWZAHFA+554Cw=; h=From:To:Cc:Subject:Date:Reply-to:From; b=CFFt9n/D5BG2QtKr8omP3xlMM/I3PJAQlRFHzympW894qbiLpWgESb+gjpVUG4d8j EMBz1nVGvyixbePYLKracDVaRNdPxOVYAKAU6HL80DbJEqgB+jURlOjHeiQ73eL6uj PLUlunVbeaZfoM7vteX40T/JulR2Cr+HyZ7nWfwc= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2025-21750: wifi: brcmfmac: Check the return value of of_property_read_string_index() Date: Wed, 26 Feb 2025 18:11:32 -0800 Message-ID: <2025022601-CVE-2025-21750-d10d@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=4071; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=ixjd9VBWy1avK4jR2CXtqT46XYDYtKxWZAHFA+554Cw=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7T27dnVIiz3/++5cchUMezct3aYWEmQSZX95dsWrNj G7le9NYOmJZGASZGGTFFFm+bOM5ur/ikKKXoe1pmDmsTCBDGLg4BWAiu+MZ5qf535uXfbegYcWk IGHDhxvjQxWU9jDM4VEp+vVRJmA7r+3WpIfREkG/IjoXAQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: wifi: brcmfmac: Check the return value of of_property_read_string_index() Somewhen between 6.10 and 6.11 the driver started to crash on my MacBookPro14,3. The property doesn't exist and 'tmp' remains uninitialized, so we pass a random pointer to devm_kstrdup(). The crash I am getting looks like this: BUG: unable to handle page fault for address: 00007f033c669379 PF: supervisor read access in kernel mode PF: error_code(0x0001) - permissions violation PGD 8000000101341067 P4D 8000000101341067 PUD 101340067 PMD 1013bb067 PTE 800000010aee9025 Oops: Oops: 0001 [#1] SMP PTI CPU: 4 UID: 0 PID: 827 Comm: (udev-worker) Not tainted 6.11.8-gentoo #1 Hardware name: Apple Inc. MacBookPro14,3/Mac-551B86E5744E2388, BIOS 529.140.2.0.0 06/23/2024 RIP: 0010:strlen+0x4/0x30 Code: f7 75 ec 31 c0 c3 cc cc cc cc 48 89 f8 c3 cc cc cc cc 0f 1f 40 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa <80> 3f 00 74 14 48 89 f8 48 83 c0 01 80 38 00 75 f7 48 29 f8 c3 cc RSP: 0018:ffffb4aac0683ad8 EFLAGS: 00010202 RAX: 00000000ffffffea RBX: 00007f033c669379 RCX: 0000000000000001 RDX: 0000000000000cc0 RSI: 00007f033c669379 RDI: 00007f033c669379 RBP: 00000000ffffffea R08: 0000000000000000 R09: 00000000c0ba916a R10: ffffffffffffffff R11: ffffffffb61ea260 R12: ffff91f7815b50c8 R13: 0000000000000cc0 R14: ffff91fafefffe30 R15: ffffb4aac0683b30 FS: 00007f033ccbe8c0(0000) GS:ffff91faeed00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f033c669379 CR3: 0000000107b1e004 CR4: 00000000003706f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: ? __die+0x23/0x70 ? page_fault_oops+0x149/0x4c0 ? raw_spin_rq_lock_nested+0xe/0x20 ? sched_balance_newidle+0x22b/0x3c0 ? update_load_avg+0x78/0x770 ? exc_page_fault+0x6f/0x150 ? asm_exc_page_fault+0x26/0x30 ? __pfx_pci_conf1_write+0x10/0x10 ? strlen+0x4/0x30 devm_kstrdup+0x25/0x70 brcmf_of_probe+0x273/0x350 [brcmfmac] The Linux kernel CVE team has assigned CVE-2025-21750 to this issue. Affected and fixed versions =========================== Fixed in 6.1.129 with commit af525a8b2ab85291617e79a5bb18bcdcb529e80c Fixed in 6.6.78 with commit c9480e9f2d10135476101619bcbd1c49c15d595f Fixed in 6.12.14 with commit 7ef2ea1429684d5cef207519bdf6ce45e50e8ac5 Fixed in 6.13.3 with commit bb8e35e33e79eb8e44396adbc8cb6c8c5f16b731 Fixed in 6.14-rc1 with commit 082d9e263af8de68f0c34f67b251818205160f6e Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2025-21750 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/af525a8b2ab85291617e79a5bb18bcdcb529e80c https://git.kernel.org/stable/c/c9480e9f2d10135476101619bcbd1c49c15d595f https://git.kernel.org/stable/c/7ef2ea1429684d5cef207519bdf6ce45e50e8ac5 https://git.kernel.org/stable/c/bb8e35e33e79eb8e44396adbc8cb6c8c5f16b731 https://git.kernel.org/stable/c/082d9e263af8de68f0c34f67b251818205160f6e