From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7CC86C021B8 for ; Wed, 26 Feb 2025 07:25:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 07AEE10E85F; Wed, 26 Feb 2025 07:25:20 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="UbDAUJSP"; dkim-atps=neutral Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9934410E85F for ; Wed, 26 Feb 2025 07:25:16 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 5CBF2441C4; Wed, 26 Feb 2025 07:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740554714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c8mj65+pl/QUAcncSVFmPbyy7s7I9gO0TgTOYjN9bpw=; b=UbDAUJSPj8Mt3qUiUv/IJ7qqiGZv2Arxe0YEnLQBZmNMHDm1bADYE+rtiKrN0b4OAM1+eD 9C6Tthn0OGceshavOjzra15AxKa6TfAEQvyE1i281ueOLcURbbufFKCQpaI939ti9zX3Q3 ugbzRjIUNC+gq1AKmFsrc9wipFEkQp3UTMMpvdPKYJJNpDpWAuX5DNncszaw9oe+PrcFkY A0RofZCq1FOgtnknke3cUor+nJxeJ6w6929uOlCFap9jLN/Zc0Q0HwS2V11yTEQI706icU PUAyXK1McWM/lDbeV1WX0IzjVt74PdfgPsDPGri00bp2vSFKnISMLUqxC5z7Xw== Date: Wed, 26 Feb 2025 08:25:12 +0100 From: Herve Codina To: Alexander Stein Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Support negative DE polarity Message-ID: <20250226082512.6a06e9f7@bootlin.com> In-Reply-To: <20250225135114.801884-1-alexander.stein@ew.tq-group.com> References: <20250225135114.801884-1-alexander.stein@ew.tq-group.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekfeelkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfohfogggtgfesthekredtredtjeenucfhrhhomhepjfgvrhhvvgcuvehoughinhgruceohhgvrhhvvgdrtghoughinhgrsegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeeviefffeegiedtleelieeghfejleeuueevkeevteegffehledtkeegudeigffgvdenucfkphepvdgrtddumegvtdgrmedvgeeimeejjeeltdemvdeitgegmegvvddvmeeitdefugemheekrgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtudemvgdtrgemvdegieemjeejledtmedviegtgeemvgdvvdemiedtfegumeehkegrpdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehhvghrvhgvrdgtohguihhnrgessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudegpdhrtghpthhtoheprghlvgigrghnuggvrhdrshhtvghinhesvgifrdhtqhdqghhrohhuphdrtghomhdprhgtphhtthhopegrnhgurhiivghjrdhhrghjuggrsehinhhtvghlrdgtohhmpdhrtghpthhtohepnhgvihhlrdgrrhhmshhtrhhonhhgsehlihhnrghrohdrohhrghdprhgtphhtt hhopehrfhhoshhssehkvghrnhgvlhdrohhrghdprhgtphhtthhopefnrghurhgvnhhtrdhpihhntghhrghrthesihguvggrshhonhgsohgrrhgurdgtohhmpdhrtghpthhtohepjhhonhgrsheskhifihgsohhordhsvgdprhgtphhtthhopehjvghrnhgvjhdrshhkrhgrsggvtgesghhmrghilhdrtghomhdprhgtphhtthhopehmrggrrhhtvghnrdhlrghnkhhhohhrshhtsehlihhnuhigrdhinhhtvghlrdgtohhm X-GND-Sasl: herve.codina@bootlin.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Alexander, On Tue, 25 Feb 2025 14:51:13 +0100 Alexander Stein wrote: > Polarity for DE is stored in bridge state. Use this flag for setting > the DE polarity in the bridge. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > index 54ad462d17ef7..95563aa1b450d 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > @@ -561,6 +561,8 @@ static void sn65dsi83_atomic_pre_enable(struct drm_bridge *bridge, > REG_LVDS_FMT_HS_NEG_POLARITY : 0) | > (mode->flags & DRM_MODE_FLAG_NVSYNC ? > REG_LVDS_FMT_VS_NEG_POLARITY : 0); > + val |= bridge_state->output_bus_cfg.flags & DRM_BUS_FLAG_DE_LOW ? > + REG_LVDS_FMT_DE_NEG_POLARITY : 0; > > /* Set up bits-per-pixel, 18bpp or 24bpp. */ > if (lvds_format_24bpp) { Tested without regression on my system. Tested-by: Herve Codina Best regards, Hervé