All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v4 7/8] drm/i915/lobf: Add mutex for alpm update
Date: Wed, 26 Feb 2025 12:48:35 +0800	[thread overview]
Message-ID: <202502261244.aUuaLdTn-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250224080847.326350-8-animesh.manna@intel.com>
References: <20250224080847.326350-8-animesh.manna@intel.com>
TO: Animesh Manna <animesh.manna@intel.com>
TO: intel-gfx@lists.freedesktop.org
TO: intel-xe@lists.freedesktop.org
CC: jouni.hogander@intel.com
CC: jani.nikula@intel.com
CC: jeevan.b@intel.com
CC: Animesh Manna <animesh.manna@intel.com>

Hi Animesh,

kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.14-rc4]
[also build test WARNING on linus/master next-20250225]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Animesh-Manna/drm-i915-lobf-Add-lobf-enablement-in-post-plane-update/20250224-221647
base:   v6.14-rc4
patch link:    https://lore.kernel.org/r/20250224080847.326350-8-animesh.manna%40intel.com
patch subject: [PATCH v4 7/8] drm/i915/lobf: Add mutex for alpm update
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: i386-randconfig-141-20250225 (https://download.01.org/0day-ci/archive/20250226/202502261244.aUuaLdTn-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202502261244.aUuaLdTn-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/i915/display/intel_alpm.c:548 intel_alpm_disable() warn: inconsistent returns '&intel_dp->alpm_parameters.lock'.

vim +548 drivers/gpu/drm/i915/display/intel_alpm.c

026d6557dc2749d Animesh Manna 2025-02-24  526  
026d6557dc2749d Animesh Manna 2025-02-24  527  void intel_alpm_disable(struct intel_dp *intel_dp)
026d6557dc2749d Animesh Manna 2025-02-24  528  {
026d6557dc2749d Animesh Manna 2025-02-24  529  	struct intel_display *display = to_intel_display(intel_dp);
026d6557dc2749d Animesh Manna 2025-02-24  530  	enum transcoder cpu_transcoder = intel_dp->alpm_parameters.transcoder;
026d6557dc2749d Animesh Manna 2025-02-24  531  
026d6557dc2749d Animesh Manna 2025-02-24  532  	if (DISPLAY_VER(display) < 20)
026d6557dc2749d Animesh Manna 2025-02-24  533  		return;
026d6557dc2749d Animesh Manna 2025-02-24  534  
737b2873a48f3ab Animesh Manna 2025-02-24  535  	mutex_lock(&intel_dp->alpm_parameters.lock);
737b2873a48f3ab Animesh Manna 2025-02-24  536  
026d6557dc2749d Animesh Manna 2025-02-24  537  	if (!(intel_de_read(display, ALPM_CTL(display, cpu_transcoder)) & ALPM_CTL_ALPM_ENABLE))
026d6557dc2749d Animesh Manna 2025-02-24  538  		return;
026d6557dc2749d Animesh Manna 2025-02-24  539  
026d6557dc2749d Animesh Manna 2025-02-24  540  	intel_de_rmw(display, ALPM_CTL(display, cpu_transcoder),
026d6557dc2749d Animesh Manna 2025-02-24  541  		     ALPM_CTL_ALPM_ENABLE | ALPM_CTL_LOBF_ENABLE |
026d6557dc2749d Animesh Manna 2025-02-24  542  		     ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
026d6557dc2749d Animesh Manna 2025-02-24  543  
026d6557dc2749d Animesh Manna 2025-02-24  544  	intel_de_rmw(display,
026d6557dc2749d Animesh Manna 2025-02-24  545  		     PORT_ALPM_CTL(cpu_transcoder),
026d6557dc2749d Animesh Manna 2025-02-24  546  		     PORT_ALPM_CTL_ALPM_AUX_LESS_ENABLE, 0);
737b2873a48f3ab Animesh Manna 2025-02-24  547  
737b2873a48f3ab Animesh Manna 2025-02-24 @548  	mutex_unlock(&intel_dp->alpm_parameters.lock);
026d6557dc2749d Animesh Manna 2025-02-24  549  }
28ed9ac2641c5df Animesh Manna 2025-02-24  550  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2025-02-26  4:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  4:48 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-24  8:08 [PATCH v4 0/8] LOBF enablement fix Animesh Manna
2025-02-24  8:08 ` [PATCH v4 7/8] drm/i915/lobf: Add mutex for alpm update Animesh Manna
2025-02-26  8:11   ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202502261244.aUuaLdTn-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.