From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, konishi.ryusuke@gmail.com
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.4 5.10 5.15 6.1 2/3] nilfs2: eliminate staggered calls to kunmap in nilfs_rename
Date: Thu, 27 Feb 2025 00:08:16 -0500 [thread overview]
Message-ID: <20250226162913-e81899c209764ce1@stable.kernel.org> (raw)
In-Reply-To: <20250226180247.4950-3-konishi.ryusuke@gmail.com>
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues:
ℹ️ This is part 2/3 of a series
ℹ️ Patch is missing in 6.13.y (ignore if backport was sent)
⚠️ Commit missing in all newer stable branches
The upstream commit SHA1 provided is correct: 8cf57c6df818f58fdad16a909506be213623a88e
Status in newer kernel trees:
6.13.y | Present (exact SHA1)
6.12.y | Present (exact SHA1)
6.6.y | Not found
6.1.y | Not found
Note: The patch differs from the upstream commit:
---
1: 8cf57c6df818f ! 1: 13fc7f2e9d896 nilfs2: eliminate staggered calls to kunmap in nilfs_rename
@@ Metadata
## Commit message ##
nilfs2: eliminate staggered calls to kunmap in nilfs_rename
+ commit 8cf57c6df818f58fdad16a909506be213623a88e upstream.
+
In nilfs_rename(), calls to nilfs_put_page() to release pages obtained
with nilfs_find_entry() or nilfs_dotdot() are alternated in the normal
path.
@@ Commit message
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
+ Stable-dep-of: ee70999a988b ("nilfs2: handle errors that nilfs_prepare_chunk() may return")
## fs/nilfs2/namei.c ##
-@@ fs/nilfs2/namei.c: static int nilfs_rename(struct mnt_idmap *idmap,
- inode_set_ctime_current(old_inode);
+@@ fs/nilfs2/namei.c: static int nilfs_rename(struct inode *old_dir, struct dentry *old_dentry,
+ old_inode->i_ctime = current_time(old_inode);
nilfs_delete_entry(old_de, old_page);
- nilfs_put_page(old_page);
---
NOTE: These results are for this patch alone. Full series testing will be
performed when all parts are received.
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.4.y | Success | Success |
| stable/linux-5.10.y | Success | Success |
| stable/linux-5.15.y | Success | Success |
| stable/linux-6.1.y | Success | Success |
next prev parent reply other threads:[~2025-02-27 5:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 18:00 [PATCH 5.4 5.10 5.15 6.1 0/3] nilfs2: fix potential kernel BUG on rename operations Ryusuke Konishi
2025-02-26 18:00 ` [PATCH 5.4 5.10 5.15 6.1 1/3] nilfs2: move page release outside of nilfs_delete_entry and nilfs_set_link Ryusuke Konishi
2025-02-27 5:08 ` Sasha Levin
2025-02-28 4:56 ` Sasha Levin
2025-02-26 18:00 ` [PATCH 5.4 5.10 5.15 6.1 2/3] nilfs2: eliminate staggered calls to kunmap in nilfs_rename Ryusuke Konishi
2025-02-27 5:08 ` Sasha Levin [this message]
2025-02-28 4:56 ` Sasha Levin
2025-02-26 18:00 ` [PATCH 5.4 5.10 5.15 6.1 3/3] nilfs2: handle errors that nilfs_prepare_chunk() may return Ryusuke Konishi
2025-02-27 5:08 ` Sasha Levin
2025-02-28 4:56 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226162913-e81899c209764ce1@stable.kernel.org \
--to=sashal@kernel.org \
--cc=konishi.ryusuke@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.