From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: [PATCH v3 1/5] drm/i915/hpd: Let an HPD pin be in the disabled state when handling missed IRQs
Date: Wed, 26 Feb 2025 19:19:19 +0200 [thread overview]
Message-ID: <20250226171924.2646997-2-imre.deak@intel.com> (raw)
In-Reply-To: <20250226171924.2646997-1-imre.deak@intel.com>
After suspending and resuming the detection on connectors, HPD IRQs that
arrived while the detection was suspended, are handled by scheduling the
intel_hotplug::hotplug work for them. All HPD pins must be at this point
in either the HPD_ENABLED (set for all pins during driver loading/system
resuming) or HPD_MARK_DISABLED (set by IRQ storm detection) state: the
HPD_DISABLED state for a pin can be set only from the HPD_MARK_DISABLED
state by the hotplug work after a storm detection (enabling polling on
the given pin/connector), however the hotplug work won't be scheduled
while the detection is suspended.
A follow-up change will add support for blocking the HPD IRQ handling
on a given HPD pin (without disabling the IRQ generation on it), after
which it becomes possible to see a pin in the HPD_DISABLED state when
unblocking the IRQ handling (since the blocking could've happened for an
already disabled pin). Adjust queue_work_for_missed_irqs() accordingly,
so that this function can be reused for unblocking the IRQ handling.
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/display/intel_hotplug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
index 00d7b1ccf1900..ab8e71c4b0f86 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
@@ -980,6 +980,7 @@ static void queue_work_for_missed_irqs(struct drm_i915_private *i915)
case HPD_MARK_DISABLED:
queue_work = true;
break;
+ case HPD_DISABLED:
case HPD_ENABLED:
break;
default:
--
2.44.2
next prev parent reply other threads:[~2025-02-26 17:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 17:19 [PATCH v3 0/5] drm/dp: Fix link training interrupted by HPD pulse Imre Deak
2025-02-26 17:19 ` Imre Deak [this message]
2025-02-26 17:19 ` [PATCH v3 2/5] drm/i915/hpd: Add support for blocking the IRQ handling on an HPD pin Imre Deak
2025-02-26 17:35 ` [PATCH v4 " Imre Deak
2025-02-28 17:25 ` Ville Syrjälä
2025-02-28 20:04 ` Imre Deak
2025-02-26 17:19 ` [PATCH v3 3/5] drm/i915/dp: Fix link training interrupted by a short HPD pulse Imre Deak
2025-02-26 17:19 ` [PATCH v3 4/5] drm/i915/dp: Queue a link check after link training is complete Imre Deak
2025-02-26 17:19 ` [PATCH v3 5/5] drm/i915/crt: Use intel_hpd_block/unblock() instead of intel_hpd_disable/enable() Imre Deak
2025-02-26 19:23 ` ✓ CI.Patch_applied: success for drm/dp: Fix link training interrupted by HPD pulse (rev5) Patchwork
2025-02-26 19:23 ` ✓ CI.checkpatch: " Patchwork
2025-02-26 19:24 ` ✓ CI.KUnit: " Patchwork
2025-02-26 19:41 ` ✓ CI.Build: " Patchwork
2025-02-26 19:43 ` ✓ CI.Hooks: " Patchwork
2025-02-26 19:45 ` ✗ CI.checksparse: warning " Patchwork
2025-02-26 20:04 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-26 21:17 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-27 2:44 ` ✗ Fi.CI.SPARSE: warning " Patchwork
2025-02-27 3:05 ` ✓ i915.CI.BAT: success " Patchwork
2025-02-27 7:54 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226171924.2646997-2-imre.deak@intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.