From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
andrew+netdev@lunn.ch, netdev@vger.kernel.org,
gospo@broadcom.com, somnath.kotur@broadcom.com, dw@davidwei.uk,
horms@kernel.org
Subject: Re: [PATCH net 2/3] eth: bnxt: return fail if interface is down in bnxt_queue_mem_alloc()
Date: Wed, 26 Feb 2025 18:08:00 -0800 [thread overview]
Message-ID: <20250226180800.7c0bfd38@kernel.org> (raw)
In-Reply-To: <20250226061837.1435731-3-ap420073@gmail.com>
On Wed, 26 Feb 2025 06:18:36 +0000 Taehee Yoo wrote:
> The bnxt_queue_mem_alloc() is called to allocate new queue memory when
> a queue is restarted.
> It internally accesses rx buffer descriptor corresponding to the index.
> The rx buffer descriptor is allocated and set when the interface is up
> and it's freed when the interface is down.
> So, if queue is restarted if interface is down, kernel panic occurs.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2025-02-27 2:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 6:18 [PATCH net 0/3] eth: bnxt: fix several bugs in the bnxt module Taehee Yoo
2025-02-26 6:18 ` [PATCH net 1/3] eth: bnxt: fix truesize for mb-xdp-pass case Taehee Yoo
2025-02-26 8:20 ` Somnath Kotur
2025-02-27 2:07 ` Jakub Kicinski
2025-02-27 5:00 ` Taehee Yoo
2025-02-26 6:18 ` [PATCH net 2/3] eth: bnxt: return fail if interface is down in bnxt_queue_mem_alloc() Taehee Yoo
2025-02-26 6:42 ` Somnath Kotur
2025-02-27 2:08 ` Jakub Kicinski [this message]
2025-02-26 6:18 ` [PATCH net 3/3] eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic Taehee Yoo
2025-02-26 6:46 ` Somnath Kotur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226180800.7c0bfd38@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=horms@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.