From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-fw-52002.amazon.com (smtp-fw-52002.amazon.com [52.119.213.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2A53235BF4 for ; Wed, 26 Feb 2025 18:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.119.213.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740594038; cv=none; b=I3avklvxb1DTC02dOQrnR+f+NYu9RFuSG23rwTDPjKTZymhw1MUrLyp8culgjigJtv7qLPk4oZWVEz2X852nOlL0tvRYxdyFGL9TN6RUnJDU/ofJa1kFZlUHLHWpkt74zYSljGGanOxNfTWmvNXfjrRB1/lWfiP65Qu9rapxnmo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740594038; c=relaxed/simple; bh=nUQ9c80TjFr48x+NGZJsue8mvbNhfPvvBRrhyyXNoU4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ljC0VN0k17gwyRGlrzlQq8ytiH3FPHvrgjfSHEn47FFvAVxTZMHj9xKzYmOpx3YkQaVfoQVJvKLfnbljpBYCek2uVT+/JEumE5VFnhCySlCBY7hJaj73kaQ+VmZCxAlylhZWQBuYkHPCxCj9Ws3XEDMEUwybCFybE4dtMN1rPIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b=eK22OXkf; arc=none smtp.client-ip=52.119.213.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="eK22OXkf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1740594038; x=1772130038; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SMWjdFaQi1NSsZ9LRRZG8DFE4rt/dmdIfQqKEAysT1c=; b=eK22OXkf2IVt3SV2OVJ1u5tLhA0qAJkfrRAayX3yQWfc3D83s6Lu1vfW ulduLl1KE0VZEBx2/xK2AYWaShMTVgFwog5f2IGA96q9kAoxRSR1KOcCX WMCShd8Hv/AoYPmPGQMXTLs4UTD8UNelG8u+RapSthvE60Dq45vgQdR5W 0=; X-IronPort-AV: E=Sophos;i="6.13,317,1732579200"; d="scan'208";a="700425409" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-52002.iad7.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2025 18:20:34 +0000 Received: from EX19MTAUWA001.ant.amazon.com [10.0.7.35:48106] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.29.24:2525] with esmtp (Farcaster) id 94fe871c-879c-4337-b258-ab6e8075bd85; Wed, 26 Feb 2025 18:20:32 +0000 (UTC) X-Farcaster-Flow-ID: 94fe871c-879c-4337-b258-ab6e8075bd85 Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWA001.ant.amazon.com (10.250.64.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Wed, 26 Feb 2025 18:20:31 +0000 Received: from 6c7e67bfbae3.amazon.com (10.106.101.38) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Wed, 26 Feb 2025 18:20:28 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , Subject: Re: [PATCH v1 net-next 03/12] ipv4: fib: Allocate fib_info_hash[] during netns initialisation. Date: Wed, 26 Feb 2025 10:20:19 -0800 Message-ID: <20250226182019.98268-1-kuniyu@amazon.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D039UWB003.ant.amazon.com (10.13.138.93) To EX19D004ANA001.ant.amazon.com (10.37.240.138) From: David Ahern Date: Wed, 26 Feb 2025 11:12:13 -0700 > On 2/26/25 11:09 AM, Eric Dumazet wrote: > >>> @@ -1627,6 +1633,8 @@ static int __net_init fib_net_init(struct net *net) > >>> out_proc: > >>> nl_fib_lookup_exit(net); > >>> out_nlfl: > >>> + fib4_semantics_init(net); > >> > >> _exit? > > > > Yes, this was mentioned yesterday. > > not in this code path but rather fib_net_exit. Hence me pointing out > this one only Sorry, actually I realised the path and fixed just after sending the diff yesterday. Will send v2 shortly. Thank you both for the review !