From: Eric Biggers <ebiggers@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmet-tcp: switch to using the crc32c library
Date: Wed, 26 Feb 2025 19:01:22 +0000 [thread overview]
Message-ID: <20250226190122.GA3949421@google.com> (raw)
In-Reply-To: <03dad20d-1293-47d1-a55d-8430fcefc0bb@suse.de>
On Wed, Feb 26, 2025 at 10:37:55AM +0100, Hannes Reinecke wrote:
> ... and it also eliminates a sporadic crash which we've seen
> where 'snd_hash' wasn't initialized when sending PDUs.
> Thanks for doing this!
I'm not sure how that could have happened, since the ahash was allocated when
'if (queue->hdr_digest || queue->data_digest)' which seemed to match the
conditions for when it was used. But yeah, it's certainly nice to not have the
pointless allocation to worry about.
> (Note to self: check the nvme-tls code for crc32c usage ...)
I have patches for nvme-tls almost ready too. Just been taking my time since
I've been updating all other users of "crc32" and "crc32c" in the kernel too.
And I need to decide what to do about skb_copy_and_hash_datagram_iter().
- Eric
next prev parent reply other threads:[~2025-02-26 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 6:28 [PATCH] nvmet-tcp: switch to using the crc32c library Eric Biggers
2025-02-26 9:37 ` Hannes Reinecke
2025-02-26 19:01 ` Eric Biggers [this message]
2025-02-27 7:26 ` Hannes Reinecke
2025-02-27 8:40 ` Sagi Grimberg
2025-03-02 11:49 ` David Laight
2025-02-27 10:10 ` Sagi Grimberg
2025-04-09 4:04 ` Eric Biggers
2025-04-09 8:45 ` Christoph Hellwig
2025-04-13 22:10 ` Sagi Grimberg
2025-04-22 7:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226190122.GA3949421@google.com \
--to=ebiggers@kernel.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.