From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DDE2C19776 for ; Wed, 26 Feb 2025 21:24:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 03A1810E2EB; Wed, 26 Feb 2025 21:24:55 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="h/qjkjlG"; dkim-atps=neutral Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5441E10E2E9 for ; Wed, 26 Feb 2025 21:24:51 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 6D59444356; Wed, 26 Feb 2025 21:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740605087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DV38PQTzP4LsTI2fWnjmoilBe+AerYXnM0qzYdZcLiA=; b=h/qjkjlGD45ZR2ZZFpAetj+erMRQhiGf2YyXSlVOz0WYSsqL/1+sVmvTIX+ZdYWqo54juT GHUssJ60vjltqmlJTc6AZ6BsOwxo24p2kLZ5SaQjtbN6R3OMjYAAsjuoZzliYUQgaEc3vg A+Bcwv5iaX0OeMO7BYnzftEWyavfx+aLD/gkM1HJEWzRvWh4DUv8vLltb2DQGius2m9amc UaQQg0X+88d9tsTXh4lxR53pMv27+RzTX65GB847ZZJDcar7fehmTrpIsEZqxETpxwSkTX atm17Wf0PZhjiM1zGXABQActJfHF+TkZeJ4XgprO1FLHvvjZMJQK+zw5BIMHUQ== Date: Wed, 26 Feb 2025 22:24:42 +0100 From: Luca Ceresoli To: Jani Nikula Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/2] drm/bridge: move bridges_show logic from drm_debugfs.c Message-ID: <20250226222442.2a32d706@booty> In-Reply-To: <87mse851um.fsf@intel.com> References: <20250225-drm-debugfs-show-all-bridges-v7-0-8826037ada37@bootlin.com> <20250225-drm-debugfs-show-all-bridges-v7-1-8826037ada37@bootlin.com> <878qpu56cm.fsf@intel.com> <20250225183621.6b33684b@booty> <871pvl6g1t.fsf@intel.com> <20250226123208.272e7766@booty> <87mse851um.fsf@intel.com> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekheeihecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkjghfohfogggtgfesthejredtredtvdenucfhrhhomhepnfhutggrucevvghrvghsohhlihcuoehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmqeenucggtffrrghtthgvrhhnpeeglefffefghefhtddvfeeufeeiveekgffgleekieduteekkeetvdehudekgfdvvdenucffohhmrghinhepsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeeijedtmedvtddvtdemvggrtddumegsvgegudemleehvgejmeefgeefmeeludefvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemieejtdemvddtvddtmegvrgdtudemsggvgedumeelhegvjeemfeegfeemledufegvpdhhvghlohepsghoohhthidpmhgrihhlfhhrohhmpehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopeduiedprhgtphhtthhopehjrghnihdrnhhikhhulhgrsehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtoheprghnughriigvjhdrhhgrjhgurgesihhnthgvlhdrtghomhdprhgtphhtthhopehnvghilhdrrghrmhhsthhro hhngheslhhinhgrrhhordhorhhgpdhrtghpthhtoheprhhfohhssheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepnfgruhhrvghnthdrphhinhgthhgrrhhtsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhopehjohhnrghssehkfihisghoohdrshgvpdhrtghpthhtohepjhgvrhhnvghjrdhskhhrrggsvggtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhgrrghrthgvnhdrlhgrnhhkhhhorhhstheslhhinhhugidrihhnthgvlhdrtghomh X-GND-Sasl: luca.ceresoli@bootlin.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Jani, On Wed, 26 Feb 2025 14:26:09 +0200 Jani Nikula wrote: > > Moving the last 2 lines to drm_bridge.c and into a new function we'd > > have: > > > > drm_encoder_register_all() [drm_encoder.c] > > -> drm_debugfs_encoder_add [*] [drm_debugfs.c] > > -> drm_bridge_debugfs_add_encoder_bridges_file (NEW) [drm_bridge.c] > > -> debugfs_create_file("bridges"... &bridges_fops) [drm_bridge.c] > > [bridges_fops is in drm_bridge.c] > > > > Potentially [*] could be moved to drm_encoder.c, but that is not bridge > > related and can be done as a future step. > > > > Is this what you had in mind? > > Yes! > > (Though I'd give drm_bridge_debugfs_add_encoder_bridges_file() a shorter > and more generic name.) Thanks, done. v8 on its way. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com