From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20F6B21B90B for ; Wed, 26 Feb 2025 02:27:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536855; cv=none; b=KnFnBjOL/TPQ2F6JL9E/1vCj0kN3zBHvY4I69U4P8x/QXaOyTch7g3cQr6D2vh4wuJjO8sdx/oo4r3f3txIBMMD7/SjtnyvfHSBA5BzIHb4hz//nCu99edcQPdM7Y4OibcFuG2rlrAAPfUQ/tQLfUOaezZCkSSjyOCV4HKyQAww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536855; c=relaxed/simple; bh=5T1LOluyEnlQsuyELuj46Ia7VXkLhI0g+MyIg2Dwz1g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R/nfiQyzrY+70RE4+l/mn3XizdOr+ZBtoxvagYcwjz+ySmPHnZRgB88sEEbYKYRBk48VtPSWEGSCdQAMd2pzCCvrIZjGjZ/U61SbDBiwameWwyf3d71Og48jZwKSGnhKAt9zgrr39LNhjePC4V0TSh+BViM/8JoDFushZKdDOlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eizTwDZU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eizTwDZU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6AD5C4CEE6; Wed, 26 Feb 2025 02:27:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740536855; bh=5T1LOluyEnlQsuyELuj46Ia7VXkLhI0g+MyIg2Dwz1g=; h=From:To:Cc:Subject:Date:Reply-to:From; b=eizTwDZU5beCOdr2RCgmiHqd7DsBDyIexEg5x7e67bwdZkhHKjJOgq1UFY0V5oOZK hsQWrf+gJ1498UXczQh+UkIheDjq6Q1Th+62a5EC7ECONZhgpu4PGBeYoCWB3UtQoe XDqzCJMumvZZDn3w/M+Qcu7mLaMb47aQhmIqy4u0= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-49697: bpf: Fix request_sock leak in sk lookup helpers Date: Wed, 26 Feb 2025 03:24:20 +0100 Message-ID: <2025022628-CVE-2022-49697-db0b@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3451; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=5T1LOluyEnlQsuyELuj46Ia7VXkLhI0g+MyIg2Dwz1g=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7qp7cKJxj9mzC6e7TPbNvM+X6HtZLXyoSsS51d8bcV wzLFeeodMSyMAgyMciKKbJ82cZzdH/FIUUvQ9vTMHNYmUCGMHBxCsBEbFczzOGcw/z76B6+ozIV Hy1l9lsvtQpz+8cwP3AvK9MrcXmL9dcl2LPNVt6o2vOoEAA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: bpf: Fix request_sock leak in sk lookup helpers A customer reported a request_socket leak in a Calico cloud environment. We found that a BPF program was doing a socket lookup with takes a refcnt on the socket and that it was finding the request_socket but returning the parent LISTEN socket via sk_to_full_sk() without decrementing the child request socket 1st, resulting in request_sock slab object leak. This patch retains the existing behaviour of returning full socks to the caller but it also decrements the child request_socket if one is present before doing so to prevent the leak. Thanks to Curtis Taylor for all the help in diagnosing and testing this. And thanks to Antoine Tenart for the reproducer and patch input. v2 of this patch contains, refactor as per Daniel Borkmann's suggestions to validate RCU flags on the listen socket so that it balances with bpf_sk_release() and update comments as per Martin KaFai Lau's suggestion. One small change to Daniels suggestion, put "sk = sk2" under "if (sk2 != sk)" to avoid an extra instruction. The Linux kernel CVE team has assigned CVE-2022-49697 to this issue. Affected and fixed versions =========================== Issue introduced in 5.2 with commit edbf8c01de5a104a71ed6df2bf6421ceb2836a8e and fixed in 5.4.202 with commit 8ffe2e50e9678c8373027492035f094b130437f1 Issue introduced in 5.2 with commit edbf8c01de5a104a71ed6df2bf6421ceb2836a8e and fixed in 5.10.127 with commit 516760f1d2979903eaad5b437256913c5cd98416 Issue introduced in 5.2 with commit edbf8c01de5a104a71ed6df2bf6421ceb2836a8e and fixed in 5.15.51 with commit b03607437ea81b850599f705096b05b85e7a4a71 Issue introduced in 5.2 with commit edbf8c01de5a104a71ed6df2bf6421ceb2836a8e and fixed in 5.18.8 with commit 5a62b5ba4c0ce8315b6382cd4ace81b48cd121cd Issue introduced in 5.2 with commit edbf8c01de5a104a71ed6df2bf6421ceb2836a8e and fixed in 5.19 with commit 3046a827316c0e55fc563b4fb78c93b9ca5c7c37 Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-49697 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: net/core/filter.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/8ffe2e50e9678c8373027492035f094b130437f1 https://git.kernel.org/stable/c/516760f1d2979903eaad5b437256913c5cd98416 https://git.kernel.org/stable/c/b03607437ea81b850599f705096b05b85e7a4a71 https://git.kernel.org/stable/c/5a62b5ba4c0ce8315b6382cd4ace81b48cd121cd https://git.kernel.org/stable/c/3046a827316c0e55fc563b4fb78c93b9ca5c7c37