From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38FCF21C162 for ; Wed, 26 Feb 2025 02:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536862; cv=none; b=MZE1iVX/7SH2H32M0vfHjEo4XCM/YUHitU2hiJmFfTCmDfwcYG7gTzKNl65JTMd1pU63AsxAAwdkcdeBnqNRastUVYrAVxG3syFHte/W0lsOE0QQkILS9ih9FeVlKSEQBq2L3AHptdbJtW97UNOONC/Z9b1OGWsV1spdEHl54V4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536862; c=relaxed/simple; bh=NMZ7t/28IpXRxj+1E8XMZfp0rmc6UZln4QBUtRs6MoY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=i1DvRcA3G8KLeFw4l4Div0gSvbiq8Lij+xyBC3RbwNYNO9m/HLk/p92cAaoA71ul4eiHZ+NXLJY25t1bPYVBX7OBT7lz1Vq4W7CElIJ8i4sUs3XBAPde/slishrkeqx90PMcRKlz6KKNX5WSKQCad1x5BSCk8lNwVeLtTO6/Psc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tChrKjH7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tChrKjH7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10873C4CEDD; Wed, 26 Feb 2025 02:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740536862; bh=NMZ7t/28IpXRxj+1E8XMZfp0rmc6UZln4QBUtRs6MoY=; h=From:To:Cc:Subject:Date:Reply-to:From; b=tChrKjH7bzriNMa5OG7aQP0Afuu4vLphwJ5HOMKMt8FeMYhqSArxGh8eKkU5n25dU c4Y1k59KmNWxMmEgaSuMdnbQw8GFOi24OAY3EAHtA2ALvlZ0s9Z/fvWOTQo34ame16 QSI3P6P4xNUwXFgGKG7dDmE1U+FtR07LhVVN1KA4= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-49706: zonefs: fix zonefs_iomap_begin() for reads Date: Wed, 26 Feb 2025 03:24:29 +0100 Message-ID: <2025022630-CVE-2022-49706-eed8@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=4603; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=NMZ7t/28IpXRxj+1E8XMZfp0rmc6UZln4QBUtRs6MoY=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7qp7NlWmbf+oQ7/u4qpZ7n//dZ7njf6u4YGL5svdPZ SurXc8HdsSyMAgyMciKKbJ82cZzdH/FIUUvQ9vTMHNYmUCGMHBxCsBEjqoyLOh1Kz9WWLOypkJ4 vpriUufc20m17QzzFK0sue6/ebdpu+J1kYuyOw9ml+xtAgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: zonefs: fix zonefs_iomap_begin() for reads If a readahead is issued to a sequential zone file with an offset exactly equal to the current file size, the iomap type is set to IOMAP_UNWRITTEN, which will prevent an IO, but the iomap length is calculated as 0. This causes a WARN_ON() in iomap_iter(): [17309.548939] WARNING: CPU: 3 PID: 2137 at fs/iomap/iter.c:34 iomap_iter+0x9cf/0xe80 [...] [17309.650907] RIP: 0010:iomap_iter+0x9cf/0xe80 [...] [17309.754560] Call Trace: [17309.757078] [17309.759240] ? lock_is_held_type+0xd8/0x130 [17309.763531] iomap_readahead+0x1a8/0x870 [17309.767550] ? iomap_read_folio+0x4c0/0x4c0 [17309.771817] ? lockdep_hardirqs_on_prepare+0x400/0x400 [17309.778848] ? lock_release+0x370/0x750 [17309.784462] ? folio_add_lru+0x217/0x3f0 [17309.790220] ? reacquire_held_locks+0x4e0/0x4e0 [17309.796543] read_pages+0x17d/0xb60 [17309.801854] ? folio_add_lru+0x238/0x3f0 [17309.807573] ? readahead_expand+0x5f0/0x5f0 [17309.813554] ? policy_node+0xb5/0x140 [17309.819018] page_cache_ra_unbounded+0x27d/0x450 [17309.825439] filemap_get_pages+0x500/0x1450 [17309.831444] ? filemap_add_folio+0x140/0x140 [17309.837519] ? lock_is_held_type+0xd8/0x130 [17309.843509] filemap_read+0x28c/0x9f0 [17309.848953] ? zonefs_file_read_iter+0x1ea/0x4d0 [zonefs] [17309.856162] ? trace_contention_end+0xd6/0x130 [17309.862416] ? __mutex_lock+0x221/0x1480 [17309.868151] ? zonefs_file_read_iter+0x166/0x4d0 [zonefs] [17309.875364] ? filemap_get_pages+0x1450/0x1450 [17309.881647] ? __mutex_unlock_slowpath+0x15e/0x620 [17309.888248] ? wait_for_completion_io_timeout+0x20/0x20 [17309.895231] ? lock_is_held_type+0xd8/0x130 [17309.901115] ? lock_is_held_type+0xd8/0x130 [17309.906934] zonefs_file_read_iter+0x356/0x4d0 [zonefs] [17309.913750] new_sync_read+0x2d8/0x520 [17309.919035] ? __x64_sys_lseek+0x1d0/0x1d0 Furthermore, this causes iomap_readahead() to loop forever as iomap_readahead_iter() always returns 0, making no progress. Fix this by treating reads after the file size as access to holes, setting the iomap type to IOMAP_HOLE, the iomap addr to IOMAP_NULL_ADDR and using the length argument as is for the iomap length. To simplify the code with this change, zonefs_iomap_begin() is split into the read variant, zonefs_read_iomap_begin() and zonefs_read_iomap_ops, and the write variant, zonefs_write_iomap_begin() and zonefs_write_iomap_ops. The Linux kernel CVE team has assigned CVE-2022-49706 to this issue. Affected and fixed versions =========================== Issue introduced in 5.6 with commit 8dcc1a9d90c10fa4143e5c17821082e5e60e46a1 and fixed in 5.10.125 with commit 355be6131164c5bacf2e810763835aecb6e01fcb Issue introduced in 5.6 with commit 8dcc1a9d90c10fa4143e5c17821082e5e60e46a1 and fixed in 5.15.50 with commit c2f71b9bb398e2e573bdc2574149f42b45efe410 Issue introduced in 5.6 with commit 8dcc1a9d90c10fa4143e5c17821082e5e60e46a1 and fixed in 5.18.7 with commit 3a7f05f104347b407e865c10be2675cd833a4e48 Issue introduced in 5.6 with commit 8dcc1a9d90c10fa4143e5c17821082e5e60e46a1 and fixed in 5.19 with commit c1c1204c0d0c1dccc1310b9277fb2bd8b663d8fe Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-49706 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: fs/zonefs/super.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/355be6131164c5bacf2e810763835aecb6e01fcb https://git.kernel.org/stable/c/c2f71b9bb398e2e573bdc2574149f42b45efe410 https://git.kernel.org/stable/c/3a7f05f104347b407e865c10be2675cd833a4e48 https://git.kernel.org/stable/c/c1c1204c0d0c1dccc1310b9277fb2bd8b663d8fe