From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54F49213E68 for ; Wed, 26 Feb 2025 02:13:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536019; cv=none; b=GJcJa2wRnJcQC04FKf2+nvP1OSf+98UkcCuY9hPYUS0KXSy5rU0uts1NVkYKtQ/K5k5W2vsckCPg2AWd+cs++HHO0ARW9K2tK0dWKDKDuI89tXm6bRq0c42iqxrs+oo6n347AGL5air9pJVrb5MHCwFOu8DlwavP/491rxgvhxc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536019; c=relaxed/simple; bh=wx0869pApgNkaQK1PIgHcJlhjFhXcB81tuKplrPfJEs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gdH3rkdhvRZiRVERho1r+XOqX2FQGLVHRQDOivEpPHOUbLWejpLrQIvvfMozE84Msy1vEbGcO+mpvYzLiKugN0PielwVg2GxBp400BnYOWJIXApGABUsY0dhN2l7/Od6go4cgjiVdLzUPPfyxxaRsq4byI1tnntZBXJmDwkyu48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=xBG69m0M; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="xBG69m0M" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29420C4CEDD; Wed, 26 Feb 2025 02:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740536019; bh=wx0869pApgNkaQK1PIgHcJlhjFhXcB81tuKplrPfJEs=; h=From:To:Cc:Subject:Date:Reply-to:From; b=xBG69m0MZP0j1XHn7Z6FzCAbln1sf2VtTCL8WGP3bj3QLaG3fDkKQT97COBAarD6S n/zlBgXiXnjBWBDT8hzBFmqYrKeGllRcGT6/Tp2xYvU9qfxIT3OD1jbKUIuRHO7PmJ tUkXGCc0hqaxJaLP5rYVRdXSHQyuT+Z8MAyXUvaQ= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-49340: ip_gre: test csum_start instead of transport header Date: Wed, 26 Feb 2025 03:10:14 +0100 Message-ID: <2025022640-CVE-2022-49340-419b@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=4143; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=wx0869pApgNkaQK1PIgHcJlhjFhXcB81tuKplrPfJEs=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7yp9u+1DEnPjpte9q79LLqrX/Dd+WcO8SO33+fa9o3 c2HU93XdMSyMAgyMciKKbJ82cZzdH/FIUUvQ9vTMHNYmUCGMHBxCsBE7k5jmMPdcubkffPgdfNu 3IvucDlyhpdlvxnDgs35r9Ydea20dpnQ07BFFicOqwfrbgQA X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: ip_gre: test csum_start instead of transport header GRE with TUNNEL_CSUM will apply local checksum offload on CHECKSUM_PARTIAL packets. ipgre_xmit must validate csum_start after an optional skb_pull, else lco_csum may trigger an overflow. The original check was if (csum && skb_checksum_start(skb) < skb->data) return -EINVAL; This had false positives when skb_checksum_start is undefined: when ip_summed is not CHECKSUM_PARTIAL. A discussed refinement was straightforward if (csum && skb->ip_summed == CHECKSUM_PARTIAL && skb_checksum_start(skb) < skb->data) return -EINVAL; But was eventually revised more thoroughly: - restrict the check to the only branch where needed, in an uncommon GRE path that uses header_ops and calls skb_pull. - test skb_transport_header, which is set along with csum_start in skb_partial_csum_set in the normal header_ops datapath. Turns out skbs can arrive in this branch without the transport header set, e.g., through BPF redirection. Revise the check back to check csum_start directly, and only if CHECKSUM_PARTIAL. Do leave the check in the updated location. Check field regardless of whether TUNNEL_CSUM is configured. The Linux kernel CVE team has assigned CVE-2022-49340 to this issue. Affected and fixed versions =========================== Issue introduced in 4.19.207 with commit 774430026bd9a472d08c5d3c33351a782315771a and fixed in 4.19.247 with commit 7596bd7920985f7fc8579a92e48bc53ce4475b21 Issue introduced in 5.4.148 with commit 3d32ce5472bb2ca720bef84089b85f76a705fd1a and fixed in 5.4.198 with commit 3d08bc3a5d9b2106f5c8bcf1adb73147824aa006 Issue introduced in 5.10.68 with commit 87b34cd6485192777f632f92d592f2a71d8801a6 and fixed in 5.10.122 with commit fbeb8dfa8b87ef259eef0c89e39b53962a3cf604 Issue introduced in 5.15 with commit 8a0ed250f911da31a2aef52101bc707846a800ff and fixed in 5.15.47 with commit e6b6f98fc7605c06c0a3baa70f62c534d7b4ce58 Issue introduced in 5.15 with commit 8a0ed250f911da31a2aef52101bc707846a800ff and fixed in 5.17.15 with commit 0c92d813c7c9ca2212ecd879232e7d87362fce98 Issue introduced in 5.15 with commit 8a0ed250f911da31a2aef52101bc707846a800ff and fixed in 5.18.4 with commit 0ffa268724656633af5f37a38c212326d98ebe8c Issue introduced in 5.15 with commit 8a0ed250f911da31a2aef52101bc707846a800ff and fixed in 5.19 with commit 8d21e9963bec1aad2280cdd034c8993033ef2948 Issue introduced in 5.14.7 with commit 4bf5d5224ffca069df4501ba5fcc6ded9c002ead Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-49340 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: net/ipv4/ip_gre.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/7596bd7920985f7fc8579a92e48bc53ce4475b21 https://git.kernel.org/stable/c/3d08bc3a5d9b2106f5c8bcf1adb73147824aa006 https://git.kernel.org/stable/c/fbeb8dfa8b87ef259eef0c89e39b53962a3cf604 https://git.kernel.org/stable/c/e6b6f98fc7605c06c0a3baa70f62c534d7b4ce58 https://git.kernel.org/stable/c/0c92d813c7c9ca2212ecd879232e7d87362fce98 https://git.kernel.org/stable/c/0ffa268724656633af5f37a38c212326d98ebe8c https://git.kernel.org/stable/c/8d21e9963bec1aad2280cdd034c8993033ef2948