From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDA0E2153CC for ; Wed, 26 Feb 2025 02:13:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536013; cv=none; b=gV4L5BfHGMv+ixa6vIlQa7ofsNEDpRH97rK9oKlyuUTE87p//0gxE41nc/74uwtcL4D/nPDgZBNNnZ4DVVchcU6sKeXLmDJYN9zmovFNw1qZxLk+gp+3uV311bDJxxyWtlKI8TOe6+gzc+T65LNUZ0wSw4urE1CA+ra4EgkxTGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536013; c=relaxed/simple; bh=13ARr8iql5SHVhUmJuxPQ2m7x49vTDtc96KFW2946PY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MavTCzdad4oeyYOPMGuY1Oc8KQ2lscxhFuWHk7QYm3YU6xLerxV/+TGiohC18/1FIVeyQt7SEvz8G8y9qH48Qk9PJNwqQC3bmPKfg9QdfqYQeUsJtbgXzFQ3xuj9Fe0OlTUwzJ06NB2kLWY/GzyrpXpny/u9lf8kJL6iSL1BijE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lY5YNoC1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lY5YNoC1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C20F7C4CEDD; Wed, 26 Feb 2025 02:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740536012; bh=13ARr8iql5SHVhUmJuxPQ2m7x49vTDtc96KFW2946PY=; h=From:To:Cc:Subject:Date:Reply-to:From; b=lY5YNoC1W9GYbvI6DyAz0LHzotlyPjxTMW+arqfnFNV5SDIv2EnGAQ1RIa+tKNcFb hNsU2ap0j35WwtGVLjTKbKpbwEaJXbFOZAZ3qwNLbwhaKUF1gFyNz8xXOYfEShYypz TdtWPeUAaFMkakXT2/grJxw9wqpm5hub+2TtSElY= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-49371: driver core: fix deadlock in __device_attach Date: Wed, 26 Feb 2025 03:10:45 +0100 Message-ID: <2025022646-CVE-2022-49371-30f9@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3828; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=13ARr8iql5SHVhUmJuxPQ2m7x49vTDtc96KFW2946PY=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7yl9F5nh/FGLOfWK6J23a/Zfsk7gY7MOd31yMOKo6/ dWhOKWijlgWBkEmBlkxRZYv23iO7q84pOhlaHsaZg4rE8gQBi5OAZhIz0qGBXP7OTmKXyw5sPOO Fp/+Ic6HOz5OZWaYxawl2T9LIFNeeMm88NOyQbVPNfplAA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: driver core: fix deadlock in __device_attach In __device_attach function, The lock holding logic is as follows: ... __device_attach device_lock(dev) // get lock dev async_schedule_dev(__device_attach_async_helper, dev); // func async_schedule_node async_schedule_node_domain(func) entry = kzalloc(sizeof(struct async_entry), GFP_ATOMIC); /* when fail or work limit, sync to execute func, but __device_attach_async_helper will get lock dev as well, which will lead to A-A deadlock. */ if (!entry || atomic_read(&entry_count) > MAX_WORK) { func; else queue_work_node(node, system_unbound_wq, &entry->work) device_unlock(dev) As shown above, when it is allowed to do async probes, because of out of memory or work limit, async work is not allowed, to do sync execute instead. it will lead to A-A deadlock because of __device_attach_async_helper getting lock dev. To fix the deadlock, move the async_schedule_dev outside device_lock, as we can see, in async_schedule_node_domain, the parameter of queue_work_node is system_unbound_wq, so it can accept concurrent operations. which will also not change the code logic, and will not lead to deadlock. The Linux kernel CVE team has assigned CVE-2022-49371 to this issue. Affected and fixed versions =========================== Issue introduced in 4.2 with commit 765230b5f084863183aa8adb3405ab3f32c0b16e and fixed in 5.4.198 with commit 593b595332bd2d65e1a5c1ae7897996c157f5468 Issue introduced in 4.2 with commit 765230b5f084863183aa8adb3405ab3f32c0b16e and fixed in 5.10.122 with commit 36ee9ffca8ef56c302f2855c4a5fccf61c0c1ada Issue introduced in 4.2 with commit 765230b5f084863183aa8adb3405ab3f32c0b16e and fixed in 5.15.47 with commit df6de52b80aa3b46f5ac804412355ffe2e1df93e Issue introduced in 4.2 with commit 765230b5f084863183aa8adb3405ab3f32c0b16e and fixed in 5.17.15 with commit d53a227bfcd5160ce1b61d9954901968a20651e7 Issue introduced in 4.2 with commit 765230b5f084863183aa8adb3405ab3f32c0b16e and fixed in 5.18.4 with commit 34fdd9b7def9d2fcb71bb7b0bc4848dd7313767e Issue introduced in 4.2 with commit 765230b5f084863183aa8adb3405ab3f32c0b16e and fixed in 5.19 with commit b232b02bf3c205b13a26dcec08e53baddd8e59ed Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-49371 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/base/dd.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/593b595332bd2d65e1a5c1ae7897996c157f5468 https://git.kernel.org/stable/c/36ee9ffca8ef56c302f2855c4a5fccf61c0c1ada https://git.kernel.org/stable/c/df6de52b80aa3b46f5ac804412355ffe2e1df93e https://git.kernel.org/stable/c/d53a227bfcd5160ce1b61d9954901968a20651e7 https://git.kernel.org/stable/c/34fdd9b7def9d2fcb71bb7b0bc4848dd7313767e https://git.kernel.org/stable/c/b232b02bf3c205b13a26dcec08e53baddd8e59ed