From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07D061A5B95 for ; Wed, 26 Feb 2025 01:58:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740535106; cv=none; b=LqE1PkGSExQbXgxg3kOnGGdmI6GP/gNiJzItS/PDH/DeLXTOfqueQL2mfQOCsJ+pq3dY1UEr63APzUr5IDN6tCfvQTKYbw3CySQ7to5ziiW4Y+M8KbUZHFJ13QC73o9bxF5Yz09Bu2vMT8myciumQP0PZ2u9jfKyJO1q8xu/jhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740535106; c=relaxed/simple; bh=dJDGp7Lpq4qIsVg4ba3eK6v1yj3ux/EKUul5zNn7DMk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=U1t6ZnMfGIkr3dPe0UUXZyd7zQcID0ZqU34a2JErV5Ds6isc1/uOU+2rzJkvurJMX/feq6KpMlbOsO/cLRjunvN0h6tXgSRIkH0VzxcEmnFMVwA0ettyz5eSoybH203w6/xW21nXpdy3IgQAeFVITvPfGk59q48LGUv/jtlbwi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TLciIlqj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TLciIlqj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFFC7C4CEDD; Wed, 26 Feb 2025 01:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740535105; bh=dJDGp7Lpq4qIsVg4ba3eK6v1yj3ux/EKUul5zNn7DMk=; h=From:To:Cc:Subject:Date:Reply-to:From; b=TLciIlqjRvZx1y+YpzSFL+uQ+E5fakQLJgpYs0KGz2eF7gzDkXBhod9VZuX2EKkM6 ht3572pNfqLVdBvax4mbxhU/s70NS5BdF5hlOpdKpNXmBW6yZ5pRBjo8kOGadYtViX gpdi0yarTodvUE7ekHTnYl/1fRzwmzWov4MdenZQ= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-49075: btrfs: fix qgroup reserve overflow the qgroup limit Date: Wed, 26 Feb 2025 02:54:40 +0100 Message-ID: <2025022656-CVE-2022-49075-ad31@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=4199; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=dJDGp7Lpq4qIsVg4ba3eK6v1yj3ux/EKUul5zNn7DMk=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7Skxs7Bf+yr6SJyo/rexmWk/Jvcjls5/0bHjcu3ztp VIr7v6pHbEsDIJMDLJiiixftvEc3V9xSNHL0PY0zBxWJpAhDFycAjARy3SGBStjXXIiZz/usf0f M+n5uZlTPFovNzEsuCJyZHfBi9s73RaFvBbMSQutM7pmDgA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: btrfs: fix qgroup reserve overflow the qgroup limit We use extent_changeset->bytes_changed in qgroup_reserve_data() to record how many bytes we set for EXTENT_QGROUP_RESERVED state. Currently the bytes_changed is set as "unsigned int", and it will overflow if we try to fallocate a range larger than 4GiB. The result is we reserve less bytes and eventually break the qgroup limit. Unlike regular buffered/direct write, which we use one changeset for each ordered extent, which can never be larger than 256M. For fallocate, we use one changeset for the whole range, thus it no longer respects the 256M per extent limit, and caused the problem. The following example test script reproduces the problem: $ cat qgroup-overflow.sh #!/bin/bash DEV=/dev/sdj MNT=/mnt/sdj mkfs.btrfs -f $DEV mount $DEV $MNT # Set qgroup limit to 2GiB. btrfs quota enable $MNT btrfs qgroup limit 2G $MNT # Try to fallocate a 3GiB file. This should fail. echo echo "Try to fallocate a 3GiB file..." fallocate -l 3G $MNT/3G.file # Try to fallocate a 5GiB file. echo echo "Try to fallocate a 5GiB file..." fallocate -l 5G $MNT/5G.file # See we break the qgroup limit. echo sync btrfs qgroup show -r $MNT umount $MNT When running the test: $ ./qgroup-overflow.sh (...) Try to fallocate a 3GiB file... fallocate: fallocate failed: Disk quota exceeded Try to fallocate a 5GiB file... qgroupid         rfer         excl     max_rfer --------         ----         ----     -------- 0/5           5.00GiB      5.00GiB      2.00GiB Since we have no control of how bytes_changed is used, it's better to set it to u64. The Linux kernel CVE team has assigned CVE-2022-49075 to this issue. Affected and fixed versions =========================== Fixed in 4.14.276 with commit 0355387ea5b02d353c9415613fab908fac5c52a6 Fixed in 4.19.238 with commit f3d97b22a708bf9e3f3ac2ba232bcefd0b0c136b Fixed in 5.4.189 with commit 44277c50fdba5019ca25bfad1b71e2561b0de11b Fixed in 5.10.111 with commit 82ae73ac963cee877ce34f7c31b2b456b516e96c Fixed in 5.15.34 with commit 4b98799e181b4326a613108cf37acc1f55d21b45 Fixed in 5.16.20 with commit 6bfff81286d4491f02dad7814bae5c77c9ad2320 Fixed in 5.17.3 with commit 7941b74ed49b6db25efbef2256ebef843c11a010 Fixed in 5.18 with commit b642b52d0b50f4d398cb4293f64992d0eed2e2ce Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-49075 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: fs/btrfs/extent_io.h Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/0355387ea5b02d353c9415613fab908fac5c52a6 https://git.kernel.org/stable/c/f3d97b22a708bf9e3f3ac2ba232bcefd0b0c136b https://git.kernel.org/stable/c/44277c50fdba5019ca25bfad1b71e2561b0de11b https://git.kernel.org/stable/c/82ae73ac963cee877ce34f7c31b2b456b516e96c https://git.kernel.org/stable/c/4b98799e181b4326a613108cf37acc1f55d21b45 https://git.kernel.org/stable/c/6bfff81286d4491f02dad7814bae5c77c9ad2320 https://git.kernel.org/stable/c/7941b74ed49b6db25efbef2256ebef843c11a010 https://git.kernel.org/stable/c/b642b52d0b50f4d398cb4293f64992d0eed2e2ce