From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA35F216608 for ; Wed, 26 Feb 2025 02:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536056; cv=none; b=sZIHfNVIyVp7KTq7V1wEfZD2+0e6lvURlk+i/4rA4vfiUx82bzxcQjghHFJ/zOOnjsPzafCOVv2SbihxxWVpuRG3qA296RiWDsQxPDOJ+GtKmJCgGU5FqIoUe4+i9/ci0K61yhOCRmw4NkMkL8jn3X0hw8NS4cYiaFF/ozpKBG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740536056; c=relaxed/simple; bh=sA+IqHYJ+bPuL0wIKqumS3DwAih1rk4/F3e0mYX9suA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mSZoz7Fk2z0ksEa/N/KTtLZxeuhDovh1m4r80bMa8CykeZe0qtHbu2SOq4CD70x2zgJvv/Ewfm3WgLuOy/Xtgxc6ZguHS+huzd+RhpPmckWTIZ0I61bZGH4UiC/pePnS/yNr7EiiFocKoFYBSjfa68xfFlGE5CRt99QzW6YFN24= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eeEnocYA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eeEnocYA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D2C1C4CEDD; Wed, 26 Feb 2025 02:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1740536056; bh=sA+IqHYJ+bPuL0wIKqumS3DwAih1rk4/F3e0mYX9suA=; h=From:To:Cc:Subject:Date:Reply-to:From; b=eeEnocYABSHHhJSXTL2l4vmrocndHGRcI5JvkkPg2IYFH79Ka4Mxb2ssQPeTWS5Rl IfR4ykSk6F7nKUrJwauKi2tp6uGA0MbkIO5WwLA/GAQkinqEj8/miTCy4xUvzWQJpP HeqM7aSLRRgqr+pptRMbIlX4bCetbABJYSLbYpUo= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2022-49434: PCI: Avoid pci_dev_lock() AB/BA deadlock with sriov_numvfs_store() Date: Wed, 26 Feb 2025 03:11:48 +0100 Message-ID: <2025022656-CVE-2022-49434-4a2c@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3873; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=sA+IqHYJ+bPuL0wIKqumS3DwAih1rk4/F3e0mYX9suA=; b=owGbwMvMwCRo6H6F97bub03G02pJDOn7yr/8mLnxfusWVwf7cAnWtVtSP+W9cC3oSDlk3Dd1b p7ip88fO2JZGASZGGTFFFm+bOM5ur/ikKKXoe1pmDmsTCBDGLg4BWAiLw4yLJi4zpxrV/KakIb/ uQ6f7/z/ET7d5wTD/ITH+jHle+avS6841LLKtOL18mNyWwA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: PCI: Avoid pci_dev_lock() AB/BA deadlock with sriov_numvfs_store() The sysfs sriov_numvfs_store() path acquires the device lock before the config space access lock: sriov_numvfs_store device_lock # A (1) acquire device lock sriov_configure vfio_pci_sriov_configure # (for example) vfio_pci_core_sriov_configure pci_disable_sriov sriov_disable pci_cfg_access_lock pci_wait_cfg # B (4) wait for dev->block_cfg_access == 0 Previously, pci_dev_lock() acquired the config space access lock before the device lock: pci_dev_lock pci_cfg_access_lock dev->block_cfg_access = 1 # B (2) set dev->block_cfg_access = 1 device_lock # A (3) wait for device lock Any path that uses pci_dev_lock(), e.g., pci_reset_function(), may deadlock with sriov_numvfs_store() if the operations occur in the sequence (1) (2) (3) (4). Avoid the deadlock by reversing the order in pci_dev_lock() so it acquires the device lock before the config space access lock, the same as the sriov_numvfs_store() path. [bhelgaas: combined and adapted commit log from Jay Zhou's independent subsequent posting: https://lore.kernel.org/r/20220404062539.1710-1-jianjay.zhou@huawei.com] The Linux kernel CVE team has assigned CVE-2022-49434 to this issue. Affected and fixed versions =========================== Fixed in 4.9.318 with commit da9792920ab525b8a932aa9aeee34529ad7b83f7 Fixed in 4.14.283 with commit c3c6dc1853b8bf3c718f96fd8480a6eb09ba4831 Fixed in 4.19.247 with commit aed6d4d519210c28817948f34c53b6e058e0456c Fixed in 5.4.198 with commit c9a81f9ed6ae3554621d6a50220b1bc74b67d81e Fixed in 5.10.121 with commit eff3587b9c01439b738298475e555c028ac9f55e Fixed in 5.15.46 with commit 2cdd5284035322795b0964f899eefba254cfe483 Fixed in 5.17.14 with commit ea047f51172aa68841adef7f52d375002438b8f0 Fixed in 5.18.3 with commit 59ea6b3ae51df7cd6bfd84c9c0030609b9315622 Fixed in 5.19 with commit a91ee0e9fca9d7501286cfbced9b30a33e52740a Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2022-49434 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/pci/pci.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/da9792920ab525b8a932aa9aeee34529ad7b83f7 https://git.kernel.org/stable/c/c3c6dc1853b8bf3c718f96fd8480a6eb09ba4831 https://git.kernel.org/stable/c/aed6d4d519210c28817948f34c53b6e058e0456c https://git.kernel.org/stable/c/c9a81f9ed6ae3554621d6a50220b1bc74b67d81e https://git.kernel.org/stable/c/eff3587b9c01439b738298475e555c028ac9f55e https://git.kernel.org/stable/c/2cdd5284035322795b0964f899eefba254cfe483 https://git.kernel.org/stable/c/ea047f51172aa68841adef7f52d375002438b8f0 https://git.kernel.org/stable/c/59ea6b3ae51df7cd6bfd84c9c0030609b9315622 https://git.kernel.org/stable/c/a91ee0e9fca9d7501286cfbced9b30a33e52740a