From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:76a5:b0:1be9:327d:8ee3 with SMTP id sy5csp153930njb; Thu, 27 Feb 2025 03:32:15 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXlbFRqS/xOSmPEha713tA9ko+jmFwaZVwE8eUUqFg4nTWdcvlY2hkXrJ8cEZDuE/ZkIldEfbMXR+YooQ==@linaro.org X-Google-Smtp-Source: AGHT+IFGmD+q44+yj5iEKpGNqdNj1taIdpshRivenllG0CRKmXFvgSQTfCKlBnuVjRg57mCPvPy2 X-Received: by 2002:ad4:5ce3:0:b0:6e8:99bb:f061 with SMTP id 6a1803df08f44-6e899bbf92amr22967166d6.18.1740655935209; Thu, 27 Feb 2025 03:32:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1740655935; cv=none; d=google.com; s=arc-20240605; b=erab6MwkDEAtTFNAtEOOOjvz1JeJ/cLJkIuKGANQjVeNzOzUFGzJnEw0RAWkpGXrn6 zeo+1Bv5Jkkf/125Af3yUP2Jr3+IlxD2IDhJcH5Usix+6vVWWip85ot069KLopzeJYkz 6/+Sk8fc56qfTNAoPEjk7BtB0aP/WEe2krWyFSd4Qq4zTHe4kP0+3J5p16D4pc6x0w9E xv2MDWTZBpskND9D/5nosgx60TMmKDr9+9NeRt7lX892w/l4ArhUAilqU20hyGoRB2gj p8U6pwMqQo92DeDzA9RmhV4y+gnPtTkC00m4zTOlXZD1a5DYqahcEa184hkYHjoUp3vJ GChg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=JgOGuD0LO3r/vpyWiHUB6p9A1KyXkelB/pW1w3e7vF8=; fh=eiTFkDTmnd5CRcIdB6hYRw18rtGisoYKZSwufPoKxgk=; b=H/7JM9iUo6s2UXQChQtmLzvonbJc1DWFH6x8552uMeFaI8SQCtJBlrq+OSpavF7KV0 2BVglohu01r8c9vf5JwFiTvi19iuWPHU8r01JN5VkqxWGW9YDkAOSwKnjfFofDh8qJnE YHwotlqnWeQ5t1djVSP4tHE2kgKuQPPH1yt/Txh+wkZPnfUfEkmJM6JxiYYwgEJKeLgZ b87/ywc2UQ1oA5Sd87RHHcNRtlyNn7cVjwyFPIOLYN8/YZv4+iJS6oOA23Jh1gowT6pP LqKYiXz/WhUpZtl81JgaSHN/lg20S2pYJshI5+nlghzKMYqT/+YC7oDffr0hZ2kOWOC9 P1OA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b0xJdobA; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6e8976e397bsi10958796d6.416.2025.02.27.03.32.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Feb 2025 03:32:15 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=b0xJdobA; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tnc7f-0001oM-Rx; Thu, 27 Feb 2025 06:32:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnc7d-0001ne-U8; Thu, 27 Feb 2025 06:32:10 -0500 Received: from tor.source.kernel.org ([172.105.4.254]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnc7b-0004kj-TK; Thu, 27 Feb 2025 06:32:09 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5D1E561521; Thu, 27 Feb 2025 11:31:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74EEAC4CEE4; Thu, 27 Feb 2025 11:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740655924; bh=4pQJjF/Q4Q3WBRwJ6HQNWdlWY6WeeaYy/8fF3m2MQs8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b0xJdobA/gWddOf5S4ioanDDgZe0aVgoVbbx1BL7i1rGeCzvnUTTbp6HSFUxLFcz8 zjhUDNlnIAHpVBAJey2QdC9/aH3Hlc4LwvfeqAOQOavUbFwxgzlCupE6T7PduKk5N1 ysUy6opDNfIzKwL4cpFd7VBmS2JRh0Mov83pfW2FGn7DeuRVd7mu5tB+6BQVhstCbh Q9qeWKYagE/DxGHsENEzU6kCfPaVc1HZtiGc3+m3Mh6JIDc41w18yasE7YZWNiAr2A 5s6S74eP3FvYEajG7jO69Di0B5+ooeKvNgeX6+aYDVNOwzjThv4LSC+woAFD9Yu8g6 aaiw2kKp1giuQ== Date: Thu, 27 Feb 2025 12:31:59 +0100 From: Mauro Carvalho Chehab To: Igor Mammedov , "Michael S . Tsirkin" Cc: Jonathan Cameron , Shiju Jose , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Ani Sinha , Dongjiu Geng , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/21] acpi/ghes: create an ancillary acpi_ghes_get_state() function Message-ID: <20250227123159.46cf9b72@foz.lan> In-Reply-To: References: X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=172.105.4.254; envelope-from=mchehab+huawei@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.44, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: Bgtcd53w2vf4 Em Thu, 27 Feb 2025 12:03:40 +0100 Mauro Carvalho Chehab escreveu: > Instead of having a function to check if ACPI is enabled > (acpi_ghes_present), change its logic to be more generic, > returing a pointed to AcpiGhesState. > > Such change allows cleanup the ghes GED state code, avoiding > to read it multiple times, and simplifying the code. > > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron > Reviewed-by: Igor Mammedov > --- > hw/acpi/ghes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index c3a64adfe5ed..0135ac844bcf 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -608,7 +608,7 @@ AcpiGhesState *acpi_ghes_get_state(void) > } > ags = &acpi_ged_state->ghes_state; > > - if (!ags->hw_error_le) { > + if (!ags->hw_error_le && !ags->hest_addr_le) { > return NULL; > } > return ags; Sorry, I moved most of the stuff on this patch to [PATCH 04/21] acpi/ghes: Cleanup the code which gets ghes ged state This hunk was a left over from it. I was meant to place this hunk elsewhere but I ended forgetting while waiting for the rebase bisect tests to pass. I'll move this hunk to [PATCH 06/21] acpi/ghes: add a firmware file with HEST address for the next respin (and hopefully the final one). Regards, Mauro