All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] openposix: sem_timedwait: replace sleep with tst_process_state_wait3
Date: Thu, 27 Feb 2025 14:38:51 +0100	[thread overview]
Message-ID: <20250227133851.GA3067784@pevik> (raw)
In-Reply-To: <18cb6752b375941581aa66617e52edad0913344e.1740650948.git.jstancek@redhat.com>

Hi Jan,

> This makes the test faster and also avoids a small race - when the
> time is very close to starting new second, this makes the test use
> timeout that's effectively just slightly over one second, because
> nanosecond portion is always set to 0. And previously child would
> sleep roughly one second.

LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

I also wonder if other tests with sleep(1) are relevant. e.g.

conformance/interfaces/pthread_rwlock_timedrdlock/6-2.c
conformance/interfaces/pthread_rwlock_timedwrlock/6-2.c

(There are more sleep() uses, but I suppose others aren't relevant.)

Also, some tests (e.g conformance/interfaces/clock_nanosleep/1-3.c updated few
years ago) did not updated sleep() in docs comment.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2025-02-27 13:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 10:10 [LTP] [PATCH] openposix: sem_timedwait: replace sleep with tst_process_state_wait3 Jan Stancek
2025-02-27 13:38 ` Petr Vorel [this message]
2025-02-28 12:25   ` Jan Stancek
2025-02-27 14:57 ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250227133851.GA3067784@pevik \
    --to=pvorel@suse.cz \
    --cc=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.