All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: "Jensen, Nicklas Bo" <njensen@akamai.com>
Cc: "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] Fix bug where garbage collection for nf_conncount is not skipped when jiffies wrap around
Date: Thu, 27 Feb 2025 16:48:05 +0100	[thread overview]
Message-ID: <20250227154805.GA7952@breakpoint.cc> (raw)
In-Reply-To: <EC4CB996-F5A1-4368-AAB7-F77E1B2E6A4D@akamai.com>

Jensen, Nicklas Bo <njensen@akamai.com> wrote:
> nf_conncount is supposed to skip garbage collection if it has already run garbage collection in the same jiffy. Unfortunately, this is broken when jiffies wrap around which this patch fixes.
> 
> The problem is that last_gc in the nf_conncount_list struct is an u32, but jiffies is an unsigned long which is 8 bytes on my systems. When those two are compared it only works until last_gc wraps around.
> 
> See bug report https://bugzilla.netfilter.org/show_bug.cgi?id=1778 for more details.
> 
> Signed-off-by: Nicklas Bo Jensen <njensen@akamai.com>

Reviewed-by: Florian Westphal <fw@strlen.de>

  reply	other threads:[~2025-02-27 15:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-27 13:32 [PATCH] Fix bug where garbage collection for nf_conncount is not skipped when jiffies wrap around Jensen, Nicklas Bo
2025-02-27 15:48 ` Florian Westphal [this message]
2025-02-27 15:49 ` Florian Westphal
2025-03-05 21:49 ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250227154805.GA7952@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=njensen@akamai.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.