From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E6B5C19F2E for ; Thu, 27 Feb 2025 16:13:41 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web11.14566.1740672818519443424 for ; Thu, 27 Feb 2025 08:13:39 -0800 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id F12C640C37; Thu, 27 Feb 2025 16:13:37 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HTucEuwe6uTE; Thu, 27 Feb 2025 16:13:37 +0000 (UTC) Received: from mail.denix.org (pool-100-15-87-159.washdc.fios.verizon.net [100.15.87.159]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id B454E407E5; Thu, 27 Feb 2025 16:13:33 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 761301642B7; Thu, 27 Feb 2025 11:13:33 -0500 (EST) Date: Thu, 27 Feb 2025 11:13:33 -0500 From: Denys Dmytriyenko To: Randolph Sapp Cc: reatmon@ti.com, meta-arago@lists.yoctoproject.org, detheridge@ti.com, vijayp@ti.com Subject: Re: [meta-arago][scarthgap/master][PATCH] packagegroups: opencl and vulkan utilities Message-ID: <20250227161333.GJ1879@denix.org> References: <20250226201334.3807093-1-rs@ti.com> <20250226204304.GH1879@denix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 27 Feb 2025 16:13:41 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arago/message/15929 On Wed, Feb 26, 2025 at 03:20:48PM -0600, Randolph Sapp wrote: > On Wed Feb 26, 2025 at 2:43 PM CST, Denys Dmytriyenko wrote: > > On Wed, Feb 26, 2025 at 02:13:34PM -0600, rs@ti.com wrote: > >> From: Randolph Sapp > >> > >> Add package groups for OpenCL and Vulkan related utilities. > >> Conditionally install them in tisdk-default-image if we enable the > >> required distro features. > >> > >> Currently these package groups consist of clinfo and vulkaninfo > >> respectively. These are useful tools for checking device extension > >> compatibility and ICD loader functionality. > >> > >> Signed-off-by: Randolph Sapp > >> --- > >> .../recipes-core/images/tisdk-default-image.bb | 2 ++ > >> .../packagegroups/packagegroup-arago-opencl.bb | 13 +++++++++++++ > >> .../packagegroups/packagegroup-arago-vulkan.bb | 13 +++++++++++++ > >> 3 files changed, 28 insertions(+) > >> create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb > >> create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb > >> > >> diff --git a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > >> index aace490b..bc067857 100644 > >> --- a/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > >> +++ b/meta-arago-distro/recipes-core/images/tisdk-default-image.bb > >> @@ -17,6 +17,8 @@ IMAGE_INSTALL += "\ > >> ti-test-extras \ > >> ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-graphics','',d)} \ > >> ${@bb.utils.contains('DISTRO_FEATURES','opengl','packagegroup-arago-tisdk-gtk','',d)} \ > >> + ${@bb.utils.contains('DISTRO_FEATURES','opencl','packagegroup-arago-opencl','',d)} \ > >> + ${@bb.utils.contains('DISTRO_FEATURES','vulkan','packagegroup-arago-vulkan','',d)} \ > >> packagegroup-arago-tisdk-connectivity \ > >> packagegroup-arago-tisdk-crypto \ > >> packagegroup-arago-tisdk-multimedia \ > >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb > >> new file mode 100644 > >> index 00000000..49b6efc8 > >> --- /dev/null > >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-opencl.bb > >> @@ -0,0 +1,13 @@ > >> +DESCRIPTION = "Group containing various useful 0penCL packages" > > > > SUMMARY is required these days. > > > > > >> +LICENSE = "MIT" > > Verifying against oe-core I see that LICENSE is no longer being populated as > well. Do you want me to drop that or not? packagegroup.bbclass already weakly sets LICENSE to MIT, so unless you set a different license, you don't need it. > >> +PR = "r0" > > > > No explicit PR is needed these days. > > > > > >> +PACKAGE_ARCH = "${MACHINE_ARCH}" Also, I was wondering why you set these packagroups as machine-specific. > >> +inherit packagegroup features_check > >> + > >> +REQUIRED_DISTRO_FEATURES = "opencl" > >> + > >> +RDEPENDS:${PN} = "\ > >> + clinfo \ > >> +" > >> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb > >> new file mode 100644 > >> index 00000000..36ee4b7b > >> --- /dev/null > >> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-vulkan.bb > >> @@ -0,0 +1,13 @@ > >> +DESCRIPTION = "Group containing various useful Vulkan packages" > >> +LICENSE = "MIT" > >> +PR = "r0" > > > > Same 2 comments as above. > > > > > >> +PACKAGE_ARCH = "${MACHINE_ARCH}" > >> + > >> +inherit packagegroup features_check > >> + > >> +REQUIRED_DISTRO_FEATURES = "vulkan" > >> + > >> +RDEPENDS:${PN} = "\ > >> + vulkan-tools \ > >> +" > >> -- > >> 2.48.1