Re: [PATCH v3 4/4] ftrace: Add arguments to function tracer

[kernel test robot <lkp@intel.com>]

Hi Steven,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.14-rc4 next-20250227]
[cannot apply to trace/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Steven-Rostedt/ftrace-Add-print_function_args/20250226-063252
base:   linus/master
patch link:    https://lore.kernel.org/r/20250225222654.069143074%40goodmis.org
patch subject: [PATCH v3 4/4] ftrace: Add arguments to function tracer
config: i386-randconfig-002-20250227 (https://download.01.org/0day-ci/archive/20250228/202502280024.KCZLllFN-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250228/202502280024.KCZLllFN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502280024.KCZLllFN-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/trace/trace_output.c:1121:19: error: use of undeclared identifier 'FTRACE_REGS_MAX_ARGS'
    1121 |         if (args_size >= FTRACE_REGS_MAX_ARGS * sizeof(long))
         |                          ^
   1 error generated.
--
>> kernel/trace/trace.c:2888:10: error: use of undeclared identifier 'FTRACE_REGS_MAX_ARGS'
    2888 |         size += FTRACE_REGS_MAX_ARGS * !!fregs * sizeof(long);
         |                 ^
   kernel/trace/trace.c:2899:23: error: use of undeclared identifier 'FTRACE_REGS_MAX_ARGS'
    2899 |                 for (int i = 0; i < FTRACE_REGS_MAX_ARGS; i++)
         |                                     ^
>> kernel/trace/trace.c:2900:21: error: call to undeclared function 'ftrace_regs_get_argument'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    2900 |                         entry->args[i] = ftrace_regs_get_argument(fregs, i);
         |                                          ^
   3 errors generated.


vim +/FTRACE_REGS_MAX_ARGS +1121 kernel/trace/trace_output.c

  1108	
  1109	/* TRACE_FN */
  1110	static enum print_line_t trace_fn_trace(struct trace_iterator *iter, int flags,
  1111						struct trace_event *event)
  1112	{
  1113		struct ftrace_entry *field;
  1114		struct trace_seq *s = &iter->seq;
  1115		unsigned long *args;
  1116		int args_size;
  1117	
  1118		trace_assign_type(field, iter->ent);
  1119	
  1120		args_size = iter->ent_size - offsetof(struct ftrace_entry, args);
> 1121		if (args_size >= FTRACE_REGS_MAX_ARGS * sizeof(long))
  1122			args = field->args;
  1123		else
  1124			args = NULL;
  1125	
  1126		print_fn_trace(s, field->ip, field->parent_ip, iter->tr->text_delta,
  1127			       args, flags);
  1128		trace_seq_putc(s, '\n');
  1129	
  1130		return trace_handle_return(s);
  1131	}
  1132	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki