From: Saeed Mahameed <saeed@kernel.org>
To: stephen@networkplumber.org, dsahern@gmail.com,
Jiri Pirko <jiri@nvidia.com>,
jiri@resnulli.us
Cc: netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>
Subject: [PATCH iproute2 09/10] devlink: helper function to parse param vlaue attributes into dl_param
Date: Thu, 27 Feb 2025 18:18:36 -0800 [thread overview]
Message-ID: <20250228021837.880041-10-saeed@kernel.org> (raw)
In-Reply-To: <20250228021837.880041-1-saeed@kernel.org>
From: Saeed Mahameed <saeedm@nvidia.com>
Centralized location to parse different types of param values.
This is useful for upcoming new type of parameters support to be added
to dl_param related functions.
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
devlink/devlink.c | 68 ++++++++++++++++++++++++++++++-----------------
1 file changed, 43 insertions(+), 25 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index 3ecf8d9a..2ad15b45 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -3773,6 +3773,40 @@ static int dl_param_mnl_put(struct nlmsghdr *nlh, struct dl_param *param)
return 0;
}
+/* dl_param_val_attr_parse: parse the value attribute and store the value
+ * in the dl_param struct
+ * @data_attr: value data attribute
+ * @nla_type: type of the value attribute
+ * @param: dl_param struct to store the value
+ */
+static int
+dl_param_val_attr_parse(struct nlattr *data_attr,
+ enum devlink_dyn_attr_type type,
+ struct dl_param *param)
+{
+ switch (type) {
+ case DEVLINK_DYN_ATTR_TYPE_U8:
+ param->value.vu8 = mnl_attr_get_u8(data_attr);
+ break;
+ case DEVLINK_DYN_ATTR_TYPE_U16:
+ param->value.vu16 = mnl_attr_get_u16(data_attr);
+ break;
+ case DEVLINK_DYN_ATTR_TYPE_U32:
+ param->value.vu32 = mnl_attr_get_u32(data_attr);
+ break;
+ case DEVLINK_DYN_ATTR_TYPE_STRING:
+ param->value.vstr = mnl_attr_get_str(data_attr);
+ break;
+ case DEVLINK_DYN_ATTR_TYPE_FLAG:
+ param->value.vbool = data_attr ? true : false;
+ break;
+ default:
+ pr_err("Value type(%d) not supported\n", type);
+ return -ENOTSUP;
+ }
+ return 0;
+}
+
static int cmd_param_set_cb(const struct nlmsghdr *nlh, void *data)
{
struct genlmsghdr *genl = mnl_nlmsg_get_payload(nlh);
@@ -3805,7 +3839,7 @@ static int cmd_param_set_cb(const struct nlmsghdr *nlh, void *data)
mnl_attr_for_each_nested(param_value_attr,
nla_param[DEVLINK_ATTR_PARAM_VALUES_LIST]) {
struct nlattr *nla_value[DEVLINK_ATTR_MAX + 1] = {};
- struct nlattr *val_attr;
+ struct nlattr *data_attr;
err = mnl_attr_parse_nested(param_value_attr,
attr_cb, nla_value);
@@ -3818,30 +3852,14 @@ static int cmd_param_set_cb(const struct nlmsghdr *nlh, void *data)
return MNL_CB_ERROR;
cmode = mnl_attr_get_u8(nla_value[DEVLINK_ATTR_PARAM_VALUE_CMODE]);
- if (cmode == dl->opts.cmode) {
- param->cmode_found = true;
- val_attr = nla_value[DEVLINK_ATTR_PARAM_VALUE_DATA];
- switch (type) {
- case DEVLINK_DYN_ATTR_TYPE_U8:
- param->value.vu8 = mnl_attr_get_u8(val_attr);
- break;
- case DEVLINK_DYN_ATTR_TYPE_U16:
- param->value.vu16 = mnl_attr_get_u16(val_attr);
- break;
- case DEVLINK_DYN_ATTR_TYPE_U32:
- param->value.vu32 = mnl_attr_get_u32(val_attr);
- break;
- case DEVLINK_DYN_ATTR_TYPE_STRING:
- param->value.vstr = mnl_attr_get_str(val_attr);
- break;
- case DEVLINK_DYN_ATTR_TYPE_FLAG:
- param->value.vbool = val_attr ? true : false;
- break;
- default:
- break;
- }
- break;
- }
+ if (cmode != dl->opts.cmode)
+ continue;
+
+ param->cmode_found = true;
+ data_attr = nla_value[DEVLINK_ATTR_PARAM_VALUE_DATA];
+ if (dl_param_val_attr_parse(data_attr, type, param))
+ return MNL_CB_ERROR;
+ break;
}
param->type = type;
return MNL_CB_OK;
--
2.48.1
next prev parent reply other threads:[~2025-02-28 2:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 2:18 [PATCH iproute2 00/10] devlink params nested multi-attribute values Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 01/10] update kernel headers Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 02/10] devlink: use dynamic attributes enum Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 03/10] devlink: param show: handle multi-attribute values Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 04/10] devlink: param set: reuse cmd_dev_param_set_cb for port params set Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 05/10] devlink: rename param_ctx to dl_param Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 06/10] devlink: helper function to read user param input into dl_param Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 07/10] devlink: helper function to compare dl_params Saeed Mahameed
2025-02-28 2:18 ` [PATCH iproute2 08/10] devlink: helper function to put param value mnl attributes from dl_params Saeed Mahameed
2025-02-28 2:18 ` Saeed Mahameed [this message]
2025-02-28 2:18 ` [PATCH iproute2 10/10] devlink: params set: add support for nested attributes values Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228021837.880041-10-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=dsahern@gmail.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.