From: Jakub Kicinski <kuba@kernel.org>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Shuah Khan <shuah@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kselftest@vger.kernel.org,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Andrew Melnychenko <andrew@daynix.com>,
Stephen Hemminger <stephen@networkplumber.org>,
gur.stavi@huawei.com, Lei Yang <leiyang@redhat.com>
Subject: Re: [PATCH net-next v7 5/6] selftest: tun: Add tests for virtio-net hashing
Date: Fri, 28 Feb 2025 06:29:47 -0800 [thread overview]
Message-ID: <20250228062947.7864a59c@kernel.org> (raw)
In-Reply-To: <20250228-rss-v7-5-844205cbbdd6@daynix.com>
On Fri, 28 Feb 2025 16:58:51 +0900 Akihiko Odaki wrote:
> The added tests confirm tun can perform RSS and hash reporting, and
> reject invalid configurations for them.
The tests may benefit from using FIXTURE_VARIANT(), up to you.
The IPv4 tests fail reliably on a VM with a debug kernel
(kernel/configs/debug.config included in the config):
# 5.90 [+0.00] ok 14 tun_vnet_hash.unclassified
# 5.90 [+0.00] # RUN tun_vnet_hash.ipv4 ...
# 6.18 [+0.28] # tun.c:669:ipv4:Expected 0 (0) != tun_vnet_hash_check(self->source_fd, self->dest_fds, &packet, sizeof(packet), 0, VIRTIO_NET_HASH_REPORT_IPv4, 0x6e45d952) (0)
# 15.09 [+8.92] # ipv4: Test failed
# 15.10 [+0.00] # FAIL tun_vnet_hash.ipv4
# 15.10 [+0.00] not ok 15 tun_vnet_hash.ipv4
# 15.10 [+0.00] # RUN tun_vnet_hash.tcpv4 ...
# 15.36 [+0.26] # tun.c:689:tcpv4:Expected 0 (0) != tun_vnet_hash_check(self->source_fd, self->dest_fds, &packet, sizeof(packet), VIRTIO_NET_HDR_F_DATA_VALID, VIRTIO_NET_HASH_REPORT_TCPv4, 0xfb63539a) (0)
# 24.76 [+9.40] # tcpv4: Test failed
# 24.76 [+0.00] # FAIL tun_vnet_hash.tcpv4
# 24.76 [+0.00] not ok 16 tun_vnet_hash.tcpv4
# 24.77 [+0.00] # RUN tun_vnet_hash.udpv4 ...
# 25.05 [+0.28] # tun.c:710:udpv4:Expected 0 (0) != tun_vnet_hash_check(self->source_fd, self->dest_fds, &packet, sizeof(packet), VIRTIO_NET_HDR_F_DATA_VALID, VIRTIO_NET_HASH_REPORT_UDPv4, 0xfb63539a) (0)
# 32.11 [+7.06] # udpv4: Test failed
# 32.11 [+0.00] # FAIL tun_vnet_hash.udpv4
# 32.11 [+0.00] not ok 17 tun_vnet_hash.udpv4
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-28 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 7:58 [PATCH net-next v7 0/6] tun: Introduce virtio-net hashing feature Akihiko Odaki
2025-02-28 7:58 ` [PATCH net-next v7 1/6] virtio_net: Add functions for hashing Akihiko Odaki
2025-02-28 7:58 ` [PATCH net-next v7 2/6] net: flow_dissector: Export flow_keys_dissector_symmetric Akihiko Odaki
2025-02-28 7:58 ` [PATCH net-next v7 3/6] tun: Introduce virtio-net hash feature Akihiko Odaki
2025-03-04 6:58 ` Jason Wang
2025-03-06 9:59 ` Akihiko Odaki
2025-03-05 17:52 ` Simon Horman
2025-02-28 7:58 ` [PATCH net-next v7 4/6] selftest: tun: Test vnet ioctls without device Akihiko Odaki
2025-02-28 7:58 ` [PATCH net-next v7 5/6] selftest: tun: Add tests for virtio-net hashing Akihiko Odaki
2025-02-28 14:29 ` Jakub Kicinski [this message]
2025-03-03 6:20 ` Akihiko Odaki
2025-03-03 22:33 ` Jakub Kicinski
2025-02-28 7:58 ` [PATCH net-next v7 6/6] vhost/net: Support VIRTIO_NET_F_HASH_REPORT Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228062947.7864a59c@kernel.org \
--to=kuba@kernel.org \
--cc=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gur.stavi@huawei.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leiyang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.