From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [for-linus][PATCH 0/3] tracing: Fixes for v6.14
Date: Fri, 28 Feb 2025 10:30:03 -0500 [thread overview]
Message-ID: <20250228153003.725613767@goodmis.org> (raw)
Tracing fixes for v6.14:
- Fix crash from bad histogram entry
An error path in the histogram creation could leave an entry
in a link list that gets freed. Then when a new entry is added
it can cause a u-a-f bug. This is fixed by restructuring the code
so that the histogram is consistent on failure and everything is
cleaned up appropriately.
- Fix fprobe self test
The fprobe self test relies on no function being attached by ftrace.
BPF programs can attach to functions via ftrace and systemd now
does so. This causes those functions to appear in the enabled_functions
list which holds all functions attached by ftrace. The selftest also
uses that file to see if functions are being connected correctly.
It counts the functions in the file, but if there's already functions
in the file, it fails. Instead, add the number of functions in the file
at the start of the test to all the calculations during the test.
- Fix potential division by zero of the function profiler stddev
The calculated divisor that calculates the standard deviation of
the function times can overflow. If the overflow happens to land
on zero, that can cause a division by zero. Check for zero from
the calculation before doing the division.
TODO: Catch when it ever overflows and report it accordingly.
For now, just prevent the system from crashing.
git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git
trace/fixes
Head SHA1: a1a7eb89ca0b89dc1c326eeee2596f263291aca3
Heiko Carstens (1):
selftests/ftrace: Let fprobe test consider already enabled functions
Nikolay Kuratov (1):
ftrace: Avoid potential division by zero in function_stat_show()
Steven Rostedt (1):
tracing: Fix bad hist from corrupting named_triggers list
----
kernel/trace/ftrace.c | 27 +++++++++----------
kernel/trace/trace_events_hist.c | 30 +++++++++++-----------
.../ftrace/test.d/dynevent/add_remove_fprobe.tc | 18 ++++++++-----
3 files changed, 38 insertions(+), 37 deletions(-)
next reply other threads:[~2025-02-28 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 15:30 Steven Rostedt [this message]
2025-02-28 15:30 ` [for-linus][PATCH 1/3] tracing: Fix bad hist from corrupting named_triggers list Steven Rostedt
2025-02-28 15:30 ` [for-linus][PATCH 2/3] selftests/ftrace: Let fprobe test consider already enabled functions Steven Rostedt
2025-02-28 15:30 ` [for-linus][PATCH 3/3] ftrace: Avoid potential division by zero in function_stat_show() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228153003.725613767@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.