From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
<willemb@google.com>, Madhu Chittim <madhu.chittim@intel.com>,
Simon Horman <horms@kernel.org>,
Samuel Salin <Samuel.salin@intel.com>
Subject: Re: [PATCH net v2] idpf: synchronize pending IRQs after disable
Date: Fri, 28 Feb 2025 16:47:11 -0800 [thread overview]
Message-ID: <20250228164711.52f7a54a@kernel.org> (raw)
In-Reply-To: <f186dc24-8cc5-427c-868a-1162e75dd3e8@intel.com>
On Fri, 28 Feb 2025 16:59:47 -0700 Ahmed Zaki wrote:
> Most drivers call synchronize_irq() in the same order as this patch, for ex:
> bnxt_disable_int_sync()
> iavf_irq_disable()
> ice_vsi_dis_irq()
>
>
> The order is:
> 1 - disable IRQ registers
> 2 - synchronize_irq() <-- currently missed in IDPF
> 3 - delete napis
> 4 - free IRQs
>
> May be "races" is the wrong word, I will try to re-word.
I still have no idea what the problem is.
If you can't explain what the bug is let's just drop this patch :/
prev parent reply other threads:[~2025-03-01 0:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 21:16 [PATCH net v2] idpf: synchronize pending IRQs after disable Tony Nguyen
2025-02-28 22:40 ` Jakub Kicinski
2025-02-28 23:59 ` Ahmed Zaki
2025-03-01 0:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228164711.52f7a54a@kernel.org \
--to=kuba@kernel.org \
--cc=Samuel.salin@intel.com \
--cc=ahmed.zaki@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.