From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, mkarsten@uwaterloo.ca,
gerhard@engleder-embedded.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, mst@redhat.com, leiyang@redhat.com,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
virtualization@lists.linux.dev (open list:VIRTIO CORE AND NET
DRIVERS), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next v5 3/4] virtio-net: Map NAPIs to queues
Date: Fri, 28 Feb 2025 18:27:59 -0800 [thread overview]
Message-ID: <20250228182759.74de5bec@kernel.org> (raw)
In-Reply-To: <20250227185017.206785-4-jdamato@fastly.com>
On Thu, 27 Feb 2025 18:50:13 +0000 Joe Damato wrote:
> @@ -2870,9 +2883,15 @@ static void refill_work(struct work_struct *work)
> for (i = 0; i < vi->curr_queue_pairs; i++) {
> struct receive_queue *rq = &vi->rq[i];
>
> + rtnl_lock();
> virtnet_napi_disable(rq);
> + rtnl_unlock();
> +
> still_empty = !try_fill_recv(vi, rq, GFP_KERNEL);
> +
> + rtnl_lock();
> virtnet_napi_enable(rq);
> + rtnl_unlock();
Looks to me like refill_work is cancelled _sync while holding rtnl_lock
from the close path. I think this could deadlock?
--
pw-bot: cr
next prev parent reply other threads:[~2025-03-01 2:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 18:50 [PATCH net-next v5 0/4] virtio-net: Link queues to NAPIs Joe Damato
2025-02-27 18:50 ` [PATCH net-next v5 1/4] virtio-net: Refactor napi_enable paths Joe Damato
2025-02-27 18:50 ` [PATCH net-next v5 2/4] virtio-net: Refactor napi_disable paths Joe Damato
2025-02-27 18:50 ` [PATCH net-next v5 3/4] virtio-net: Map NAPIs to queues Joe Damato
2025-02-28 8:14 ` Jason Wang
2025-03-01 2:27 ` Jakub Kicinski [this message]
2025-03-03 16:46 ` Joe Damato
2025-03-03 17:00 ` Joe Damato
2025-03-03 18:33 ` Joe Damato
2025-03-04 0:03 ` Jakub Kicinski
2025-03-04 15:08 ` Joe Damato
2025-03-05 5:11 ` Jason Wang
2025-03-05 16:34 ` Joe Damato
2025-03-06 0:15 ` Jason Wang
2025-03-06 1:42 ` Joe Damato
2025-03-06 2:21 ` Jakub Kicinski
2025-03-06 17:00 ` Joe Damato
2025-03-06 18:21 ` Jakub Kicinski
2025-02-27 18:50 ` [PATCH net-next v5 4/4] virtio_net: Use persistent NAPI config Joe Damato
2025-02-28 14:39 ` [PATCH net-next v5 0/4] virtio-net: Link queues to NAPIs Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250228182759.74de5bec@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=gerhard@engleder-embedded.com \
--cc=jasowang@redhat.com \
--cc=jdamato@fastly.com \
--cc=leiyang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.