All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Venture <venture@google.com>
To: peter.maydell@linaro.org, armbru@redhat.com
Cc: qemu-devel@nongnu.org, Peter Foley <pefoley@google.com>,
	 Patrick Venture <venture@google.com>
Subject: [PATCH] util/keyval: fix msan findings
Date: Fri, 28 Feb 2025 21:20:39 +0000	[thread overview]
Message-ID: <20250228212039.1768614-1-venture@google.com> (raw)

From: Peter Foley <pefoley@google.com>

e.g.
qemu: Uninitialized value was created by an allocation of 'key_in_cur.i' in the stack frame
qemu: #0 0xaaaac49f489c in keyval_parse_one third_party/qemu/util/keyval.c:190:5

Signed-off-by: Peter Foley <pefoley@google.com>
Signed-off-by: Patrick Venture <venture@google.com>
---
 util/keyval.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/keyval.c b/util/keyval.c
index a70629a481..f33c64079d 100644
--- a/util/keyval.c
+++ b/util/keyval.c
@@ -187,7 +187,7 @@ static const char *keyval_parse_one(QDict *qdict, const char *params,
 {
     const char *key, *key_end, *val_end, *s, *end;
     size_t len;
-    char key_in_cur[128];
+    char key_in_cur[128] = {};
     QDict *cur;
     int ret;
     QObject *next;
-- 
2.48.1.711.g2feabab25a-goog



             reply	other threads:[~2025-02-28 21:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 21:20 Patrick Venture [this message]
2025-03-01  6:12 ` [PATCH] util/keyval: fix msan findings Paolo Bonzini
2025-03-01  7:14   ` Markus Armbruster
2025-03-03 16:32     ` Peter Foley
2025-03-03 18:51       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250228212039.1768614-1-venture@google.com \
    --to=venture@google.com \
    --cc=armbru@redhat.com \
    --cc=pefoley@google.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.