From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: andr2000@gmail.com, sstabellini@kernel.org,
Artem_Mygaiev@epam.com, jbeulich@suse.com, Luca.Fancellu@arm.com,
roger.pau@citrix.com, marmarek@invisiblethingslab.com,
andrew.cooper3@citrix.com, anthony.perard@vates.tech
Subject: [PATCH 2/4] [EXAMPLE] Provide an example of a malformed patch
Date: Sat, 1 Mar 2025 13:42:40 +0200 [thread overview]
Message-ID: <20250301114242.93650-3-andr2000@gmail.com> (raw)
In-Reply-To: <20250301114242.93650-1-andr2000@gmail.com>
This patch touches tools/xl and xen/. clang-format, if applied, will
only change xen/ part.
Signed-off-by: Oleksandr Andrushchenko <andr2000@gmail.com>
---
tools/xl/xl_info.c | 6 ++----
xen/drivers/char/ns16550.c | 12 +++++-------
2 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c
index 72e87eac46d1..cbb0f695685f 100644
--- a/tools/xl/xl_info.c
+++ b/tools/xl/xl_info.c
@@ -59,8 +59,7 @@ static int maybe_printf(const char *fmt, ...)
return count;
}
-static yajl_gen_status printf_info_one_json(yajl_gen hand, int domid,
- libxl_domain_config *d_config)
+static yajl_gen_status printf_info_one_json(yajl_gen hand, int domid, libxl_domain_config *d_config)
{
yajl_gen_status s;
@@ -68,8 +67,7 @@ static yajl_gen_status printf_info_one_json(yajl_gen hand, int domid,
if (s != yajl_gen_status_ok)
goto out;
- s = yajl_gen_string(hand, (const unsigned char *)"domid",
- sizeof("domid")-1);
+ s = yajl_gen_string(hand, (const unsigned char *)"domid", sizeof("domid")-1);
if (s != yajl_gen_status_ok)
goto out;
if (domid != -1)
diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index eaeb0e09d01e..53586f110008 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -340,9 +340,7 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
if ( divisor )
uart->baud = uart->clock_hz / (divisor << 4);
else
- printk(XENLOG_ERR
- "Automatic baud rate determination was requested,"
- " but a baud rate was not set up\n");
+ printk(XENLOG_ERR "Automatic baud rate determination was requested," " but a baud rate was not set up\n");
}
ns_write_reg(uart, UART_LCR, lcr);
@@ -350,8 +348,8 @@ static void ns16550_setup_preirq(struct ns16550 *uart)
ns_write_reg(uart, UART_MCR, UART_MCR_DTR | UART_MCR_RTS);
/* Enable and clear the FIFOs. Set a large trigger threshold. */
- ns_write_reg(uart, UART_FCR,
- UART_FCR_ENABLE | UART_FCR_CLRX | UART_FCR_CLTX | UART_FCR_TRG14);
+ ns_write_reg(uart, UART_FCR, UART_FCR_ENABLE | UART_FCR_CLRX |
+ UART_FCR_CLTX | UART_FCR_TRG14);
}
static void __init cf_check ns16550_init_preirq(struct serial_port *port)
@@ -398,8 +396,8 @@ static void ns16550_setup_postirq(struct ns16550 *uart)
if ( uart->irq > 0 )
{
/* Master interrupt enable; also keep DTR/RTS asserted. */
- ns_write_reg(uart,
- UART_MCR, UART_MCR_OUT2 | UART_MCR_DTR | UART_MCR_RTS);
+ ns_write_reg(uart, UART_MCR,
+ UART_MCR_OUT2 | UART_MCR_DTR | UART_MCR_RTS);
/* Enable receive interrupts. */
ns_write_reg(uart, UART_IER, UART_IER_ERDAI);
--
2.25.1
next prev parent reply other threads:[~2025-03-01 11:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 11:42 [PATCH 0/4] clang-format with examples Oleksandr Andrushchenko
2025-03-01 11:42 ` [PATCH 1/4] Add .clang-format files to enable manual coding style checks Oleksandr Andrushchenko
2025-03-03 15:05 ` Roger Pau Monné
2025-03-03 19:23 ` Oleksandr Andrushchenko
2025-03-04 8:17 ` Roger Pau Monné
2025-03-04 20:04 ` Oleksandr Andrushchenko
2025-03-01 11:42 ` Oleksandr Andrushchenko [this message]
2025-03-01 11:42 ` [PATCH 3/4] [EXAMPLE] Changes done by clang-format to the previous commit Oleksandr Andrushchenko
2025-03-01 11:42 ` [PATCH 4/4] [EXAMPLE] Whole file code style formatting Oleksandr Andrushchenko
2025-03-04 19:09 ` [PATCH 0/4] clang-format with examples Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250301114242.93650-3-andr2000@gmail.com \
--to=andr2000@gmail.com \
--cc=Artem_Mygaiev@epam.com \
--cc=Luca.Fancellu@arm.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=jbeulich@suse.com \
--cc=marmarek@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.