From: kernel test robot <lkp@intel.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: drivers/remoteproc/omap_remoteproc.c:732: warning: Function parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to_va'
Date: Sun, 2 Mar 2025 06:21:00 +0800 [thread overview]
Message-ID: <202503020637.6SBId7IR-lkp@intel.com> (raw)
Hi Peng,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: df87d843c6eb4dad31b7bf63614549dd3521fe71
commit: 40df0a91b2a5228ded8e5f75b80d28c96c6831cd remoteproc: add is_iomem to da_to_va
date: 4 years ago
config: arm-randconfig-c041-20230507 (https://download.01.org/0day-ci/archive/20250302/202503020637.6SBId7IR-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503020637.6SBId7IR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503020637.6SBId7IR-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/remoteproc/omap_remoteproc.c:732: warning: Function parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to_va'
vim +732 drivers/remoteproc/omap_remoteproc.c
34ed5a33b1218e Ohad Ben-Cohen 2011-10-20 716
530a1b57e8590f Suman Anna 2020-03-24 717 /**
530a1b57e8590f Suman Anna 2020-03-24 718 * omap_rproc_da_to_va() - internal memory translation helper
530a1b57e8590f Suman Anna 2020-03-24 719 * @rproc: remote processor to apply the address translation for
530a1b57e8590f Suman Anna 2020-03-24 720 * @da: device address to translate
530a1b57e8590f Suman Anna 2020-03-24 721 * @len: length of the memory buffer
530a1b57e8590f Suman Anna 2020-03-24 722 *
530a1b57e8590f Suman Anna 2020-03-24 723 * Custom function implementing the rproc .da_to_va ops to provide address
530a1b57e8590f Suman Anna 2020-03-24 724 * translation (device address to kernel virtual address) for internal RAMs
530a1b57e8590f Suman Anna 2020-03-24 725 * present in a DSP or IPU device). The translated addresses can be used
530a1b57e8590f Suman Anna 2020-03-24 726 * either by the remoteproc core for loading, or by any rpmsg bus drivers.
530a1b57e8590f Suman Anna 2020-03-24 727 *
530a1b57e8590f Suman Anna 2020-03-24 728 * Return: translated virtual address in kernel memory space on success,
530a1b57e8590f Suman Anna 2020-03-24 729 * or NULL on failure.
530a1b57e8590f Suman Anna 2020-03-24 730 */
40df0a91b2a522 Peng Fan 2021-03-06 731 static void *omap_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *is_iomem)
530a1b57e8590f Suman Anna 2020-03-24 @732 {
530a1b57e8590f Suman Anna 2020-03-24 733 struct omap_rproc *oproc = rproc->priv;
530a1b57e8590f Suman Anna 2020-03-24 734 int i;
530a1b57e8590f Suman Anna 2020-03-24 735 u32 offset;
530a1b57e8590f Suman Anna 2020-03-24 736
530a1b57e8590f Suman Anna 2020-03-24 737 if (len <= 0)
530a1b57e8590f Suman Anna 2020-03-24 738 return NULL;
530a1b57e8590f Suman Anna 2020-03-24 739
530a1b57e8590f Suman Anna 2020-03-24 740 if (!oproc->num_mems)
530a1b57e8590f Suman Anna 2020-03-24 741 return NULL;
530a1b57e8590f Suman Anna 2020-03-24 742
530a1b57e8590f Suman Anna 2020-03-24 743 for (i = 0; i < oproc->num_mems; i++) {
530a1b57e8590f Suman Anna 2020-03-24 744 if (da >= oproc->mem[i].dev_addr && da + len <=
530a1b57e8590f Suman Anna 2020-03-24 745 oproc->mem[i].dev_addr + oproc->mem[i].size) {
530a1b57e8590f Suman Anna 2020-03-24 746 offset = da - oproc->mem[i].dev_addr;
530a1b57e8590f Suman Anna 2020-03-24 747 /* __force to make sparse happy with type conversion */
530a1b57e8590f Suman Anna 2020-03-24 748 return (__force void *)(oproc->mem[i].cpu_addr +
530a1b57e8590f Suman Anna 2020-03-24 749 offset);
530a1b57e8590f Suman Anna 2020-03-24 750 }
530a1b57e8590f Suman Anna 2020-03-24 751 }
530a1b57e8590f Suman Anna 2020-03-24 752
530a1b57e8590f Suman Anna 2020-03-24 753 return NULL;
530a1b57e8590f Suman Anna 2020-03-24 754 }
530a1b57e8590f Suman Anna 2020-03-24 755
:::::: The code at line 732 was first introduced by commit
:::::: 530a1b57e8590f2ebbb6a35effa0efa988aabf6c remoteproc/omap: Add the rproc ops .da_to_va() implementation
:::::: TO: Suman Anna <s-anna@ti.com>
:::::: CC: Bjorn Andersson <bjorn.andersson@linaro.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-03-01 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-01 22:21 kernel test robot [this message]
2025-03-03 5:07 ` drivers/remoteproc/omap_remoteproc.c:732: warning: Function parameter or struct member 'is_iomem' not described in 'omap_rproc_da_to_va' Peng Fan
-- strict thread matches above, loose matches on Subject: below --
2025-02-16 8:46 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503020637.6SBId7IR-lkp@intel.com \
--to=lkp@intel.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.