From: Leon Romanovsky <leon@kernel.org>
To: Xin Tian <tianx@yunsilicon.com>
Cc: netdev@vger.kernel.org, andrew+netdev@lunn.ch, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, davem@davemloft.net,
jeff.johnson@oss.qualcomm.com, przemyslaw.kitszel@intel.com,
weihg@yunsilicon.com, wanry@yunsilicon.com, jacky@yunsilicon.com,
horms@kernel.org, parthiban.veerasooran@microchip.com,
masahiroy@kernel.org
Subject: Re: [PATCH net-next v7 07/14] xsc: Init auxiliary device
Date: Sun, 2 Mar 2025 14:23:31 +0200 [thread overview]
Message-ID: <20250302122331.GC1539246@unreal> (raw)
In-Reply-To: <20250228154137.216053-8-tianx@yunsilicon.com>
On Fri, Feb 28, 2025 at 11:41:38PM +0800, Xin Tian wrote:
> Our device supports both Ethernet and RDMA functionalities, and
> leveraging the auxiliary bus perfectly addresses our needs for
> managing these distinct features. This patch utilizes auxiliary
> device to handle the Ethernet functionality, while defining
> xsc_adev_list to reserve expansion space for future RDMA
> capabilities.
>
> Co-developed-by: Honggang Wei <weihg@yunsilicon.com>
> Signed-off-by: Honggang Wei <weihg@yunsilicon.com>
> Co-developed-by: Lei Yan <jacky@yunsilicon.com>
> Signed-off-by: Lei Yan <jacky@yunsilicon.com>
> Signed-off-by: Xin Tian <tianx@yunsilicon.com>
> ---
> .../ethernet/yunsilicon/xsc/common/xsc_core.h | 14 +++
> .../net/ethernet/yunsilicon/xsc/pci/Makefile | 3 +-
> .../net/ethernet/yunsilicon/xsc/pci/adev.c | 115 ++++++++++++++++++
> .../net/ethernet/yunsilicon/xsc/pci/adev.h | 14 +++
> .../net/ethernet/yunsilicon/xsc/pci/main.c | 10 ++
> 5 files changed, 155 insertions(+), 1 deletion(-)
> create mode 100644 drivers/net/ethernet/yunsilicon/xsc/pci/adev.c
> create mode 100644 drivers/net/ethernet/yunsilicon/xsc/pci/adev.h
>
The auxiliary device split logic looks right to me.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2025-03-02 12:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 15:41 [PATCH net-next v7 00/14] xsc: ADD Yunsilicon XSC Ethernet Driver Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 01/14] xsc: Add xsc driver basic framework Xin Tian
2025-03-05 2:48 ` Jakub Kicinski
2025-03-05 4:17 ` Xin Tian
2025-03-05 8:55 ` Kalesh Anakkur Purayil
2025-03-06 2:48 ` Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 02/14] xsc: Enable command queue Xin Tian
2025-03-04 13:21 ` Simon Horman
2025-03-05 5:25 ` Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 03/14] xsc: Add hardware setup APIs Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 04/14] xsc: Add qp and cq management Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 05/14] xsc: Add eq and alloc Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 06/14] xsc: Init pci irq Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 07/14] xsc: Init auxiliary device Xin Tian
2025-03-02 12:23 ` Leon Romanovsky [this message]
2025-02-28 15:41 ` [PATCH net-next v7 08/14] xsc: Add ethernet interface Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 09/14] xsc: Init net device Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 10/14] xsc: Add eth needed qp and cq apis Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 11/14] xsc: ndo_open and ndo_stop Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 12/14] xsc: Add ndo_start_xmit Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 13/14] xsc: Add eth reception data path Xin Tian
2025-02-28 15:41 ` [PATCH net-next v7 14/14] xsc: add ndo_get_stats64 Xin Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250302122331.GC1539246@unreal \
--to=leon@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jacky@yunsilicon.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parthiban.veerasooran@microchip.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tianx@yunsilicon.com \
--cc=wanry@yunsilicon.com \
--cc=weihg@yunsilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.