Re: [PATCH v2 1/4] powerpc/perf/core-book3s: Avoid loading platform pmu driver during dump kernel

[kernel test robot <lkp@intel.com>]

Hi Madhavan,

kernel test robot noticed the following build errors:

[auto build test ERROR on powerpc/next]
[also build test ERROR on powerpc/fixes linus/master v6.14-rc4 next-20250228]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Madhavan-Srinivasan/powerpc-perf-hv-24x7-Avoid-loading-hv-24x7-during-dump-kernel/20250302-022531
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/20250301182310.6832-1-maddy%40linux.ibm.com
patch subject: [PATCH v2 1/4] powerpc/perf/core-book3s: Avoid loading platform pmu driver during dump kernel
config: powerpc64-randconfig-001-20250302 (https://download.01.org/0day-ci/archive/20250302/202503021712.eVdjymsT-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250302/202503021712.eVdjymsT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503021712.eVdjymsT-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/powerpc/perf/core-book3s.c: In function 'init_ppc64_pmu':
>> arch/powerpc/perf/core-book3s.c:2599:13: error: implicit declaration of function 'is_kdump_kernel' [-Wimplicit-function-declaration]
    2599 |         if (is_kdump_kernel() || is_fadump_active())
         |             ^~~~~~~~~~~~~~~


vim +/is_kdump_kernel +2599 arch/powerpc/perf/core-book3s.c

  2587	
  2588	static int __init init_ppc64_pmu(void)
  2589	{
  2590		if (cpu_has_feature(CPU_FTR_HVMODE) && pmu_override) {
  2591			pr_warn("disabling perf due to pmu_override= command line option.\n");
  2592			on_each_cpu(do_pmu_override, NULL, 1);
  2593			return 0;
  2594		}
  2595	
  2596		/*
  2597		 * If the dump kernel is active, skip loading these drivers
  2598		 */
> 2599		if (is_kdump_kernel() || is_fadump_active())
  2600			return 0;
  2601	
  2602		/* run through all the pmu drivers one at a time */
  2603		if (!init_power5_pmu())
  2604			return 0;
  2605		else if (!init_power5p_pmu())
  2606			return 0;
  2607		else if (!init_power6_pmu())
  2608			return 0;
  2609		else if (!init_power7_pmu())
  2610			return 0;
  2611		else if (!init_power8_pmu())
  2612			return 0;
  2613		else if (!init_power9_pmu())
  2614			return 0;
  2615		else if (!init_power10_pmu())
  2616			return 0;
  2617		else if (!init_power11_pmu())
  2618			return 0;
  2619		else if (!init_ppc970_pmu())
  2620			return 0;
  2621		else
  2622			return init_generic_compat_pmu();
  2623	}
  2624	early_initcall(init_ppc64_pmu);
  2625	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki