Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Allow devices to be marked as noncoherent

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On Mon, Mar 03, 2025 at 02:56:48PM +0800, Inochi Amaoto wrote:
> A RISC-V platform can have both DMA coherent/noncoherent devices.
> Since the RISC-V architecture is marked coherent, devices should
> be marked as noncoherent when coherent devices exist.
> 
> Add dma-noncoherent property for snps,dw-axi-dmac device. It will
> be used on SG2044, and it has other coherent devices.
> 
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
> ---
> Related discussion for this property.
> 
> https://lore.kernel.org/all/20250221013758.370936-1-inochiama@gmail.com/
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 525f5f3932f5..935735a59afd 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -59,6 +59,8 @@ properties:
>      minimum: 1
>      maximum: 8
> 
> +  dma-noncoherent: true

I'd probably also add mutual exclusion, but I think that's something for
dt-schema and not for individual bindings.

Acked-by: Conor Dooley <conor.dooley@microchip.com>

> +
>    resets:
>      minItems: 1
>      maxItems: 2
> --
> 2.48.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]