From: Greg KH <gregkh@linuxfoundation.org>
To: Saalim Quadri <danascape@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: iio: ad5933: Fix CamelCase naming
Date: Mon, 3 Mar 2025 13:56:40 +0100 [thread overview]
Message-ID: <2025030301-niece-evacuate-0f05@gregkh> (raw)
In-Reply-To: <20250303125246.342704-1-danascape@gmail.com>
On Mon, Mar 03, 2025 at 06:22:46PM +0530, Saalim Quadri wrote:
> Reported by checkpatch:
>
> CHECK: Avoid CamelCase
>
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index d5544fc2fe98..a1a5eee4f736 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -43,10 +43,10 @@
> #define AD5933_CTRL_POWER_DOWN (0xA << 4)
> #define AD5933_CTRL_STANDBY (0xB << 4)
>
> -#define AD5933_CTRL_RANGE_2000mVpp (0x0 << 1)
> -#define AD5933_CTRL_RANGE_200mVpp (0x1 << 1)
> -#define AD5933_CTRL_RANGE_400mVpp (0x2 << 1)
> -#define AD5933_CTRL_RANGE_1000mVpp (0x3 << 1)
> +#define AD5933_CTRL_RANGE_2000MVPP (0x0 << 1)
> +#define AD5933_CTRL_RANGE_200MVPP (0x1 << 1)
> +#define AD5933_CTRL_RANGE_400MVPP (0x2 << 1)
> +#define AD5933_CTRL_RANGE_1000MVPP (0x3 << 1)
No, these are units of measurement, the "m" is correct here, right? If
you change that to "M" it logically means something a lot different :(
Please always treat checkpatch.pl as a hint, not as a rule.
thanks,
greg k-h
next prev parent reply other threads:[~2025-03-03 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 12:52 [PATCH] staging: iio: ad5933: Fix CamelCase naming Saalim Quadri
2025-03-03 12:56 ` Greg KH [this message]
2025-03-03 18:07 ` Saalim Quadri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025030301-niece-evacuate-0f05@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=danascape@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.