From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFE4BC282C5 for ; Mon, 3 Mar 2025 09:54:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 979B3817A5; Mon, 3 Mar 2025 09:54:14 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id NrjhBx20fPVO; Mon, 3 Mar 2025 09:54:14 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 037A6817B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1740995654; bh=icdFmXVOuKG1LWZIixX9Ngewj2JAW4a5Y5os+23m3mg=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=w7OszWY4DuInQUlj5zhWaE93LkWU6PxWxwCFScWxn2DdwgZSyw4NHMouFDOKMion/ d3W26LTveNuqo4y+P0GwalHxGi4jCA8XebmMpbJRpuAY8UmDcEVfsS+ZgrUR9+U/oo Gjkm1jdjges9iCIEjRQA1doqv2TJiQaju8EVhnbSK4xyZ8+W40yP559Eq8lgVPzIXF UIDWsRye633qt3oOpCbtc2txrDLIukJqHcSNEohMNrTUrGpwz6FIIoVrcSk8WJRn92 skpTccRQs9HOwCoLBNF2ySrc+lFmIH5SJt1xUs0lp7KNNWoyb+75XRhEhLqJfvRUd5 p8waUTDWfTbMg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id 037A6817B1; Mon, 3 Mar 2025 09:54:14 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists1.osuosl.org (Postfix) with ESMTP id 688E6D2 for ; Mon, 3 Mar 2025 09:54:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C025140A05 for ; Mon, 3 Mar 2025 09:54:11 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TBeZ7fGqCH-l for ; Mon, 3 Mar 2025 09:54:11 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org E04C2402F3 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E04C2402F3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id E04C2402F3 for ; Mon, 3 Mar 2025 09:54:10 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CF67F5C57C9; Mon, 3 Mar 2025 09:51:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEAA4C4CEE4; Mon, 3 Mar 2025 09:54:07 +0000 (UTC) Date: Mon, 3 Mar 2025 09:54:05 +0000 From: Simon Horman To: Mateusz Polchlopek Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Marcin Szycik , Michal Swiatkowski , Jedrzej Jagielski , Przemek Kitszel , Aleksandr Loktionov Message-ID: <20250303095405.GQ1615191@kernel.org> References: <20250226113409.446325-1-mateusz.polchlopek@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250226113409.446325-1-mateusz.polchlopek@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740995649; bh=c1Lvome+23UjOHK9xCkGg5jc+J3HRiu4lPiJ5XsX5+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mJljErG/qqeholJw9y2TbK8znKFffbrWOEldE4B80HZmwVtHQZSPDMn68sHrPlGNq SxBai8slwoaFcRlVcEXoAwl4C+lkhJ6Yy6clS6U0ONmT39iI24IX2xg+ar7sa6s39Q eF6ghjIkV+wljcNjvaFjgUPRFuFqGBWZmW26HbEcrlqaAJr78fAOtbm9M0gVEV0/qj hQ81CoBrX5A5dJri6UUBEU77rMZL3e8HYInNv2glV1MWJtZCxgeiK4j9JRR+OutWns DzZcC6kvI85KkUcf66YVd0Awx4qxl8mYMDxN0zZwPuLcWknhmGQ7aoUbtFYw2WhOK0 GlJeypV2H+GWA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=mJljErG/ Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ice: refactor the Tx scheduler feature X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, Feb 26, 2025 at 12:33:56PM +0100, Mateusz Polchlopek wrote: > Embed ice_get_tx_topo_user_sel() inside the only caller: > ice_devlink_tx_sched_layers_get(). > Instead of jump from the wrapper to the function that does "get" operation > it does "get" itself. > > Remove unnecessary comment and make usage of str_enabled_disabled() > in ice_init_tx_topology(). Hi Mateusz, These changes seem reasonable to me. But I wonder if they could be motivated in the commit message. What I mean is, the commit message explains what has been done. But I think it should explain why it has been done. > Suggested-by: Marcin Szycik > Reviewed-by: Michal Swiatkowski > Reviewed-by: Jedrzej Jagielski > Reviewed-by: Przemek Kitszel > Reviewed-by: Aleksandr Loktionov > Signed-off-by: Mateusz Polchlopek ...