From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B924CA94A; Mon, 3 Mar 2025 10:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740997675; cv=none; b=naMljt/t5RyAqVZFC9XSiEWKsyiIKbZKzWxCNK3naxFDG75sihG/JWFRoJ9CfpGQbRrc5dvlhF699Qw7V/5Y8Hm9H4N2J2GT6OeAhi8OnLDZMVWxRNGvO4wfXevgoDyksDc4jM6871cYJVS9XxcaNPaDduZ8FSzrAuZ2R8YgwzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740997675; c=relaxed/simple; bh=0OdUdx+lahN2+LUJ2jOFDFj83SCLzyn+8zKWv0oeisM=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tj5no22P2CJXOm+j0Wgfam6QaqHey4WSca3xpeOG2oiGIQypCto3ndGmxVd7FrNHfTxf48Irv6lMNWN3KAapt2E+JyCge3SQAstJh1UK37aKGKaqbbrc7hj4+lLNWm8FNFEpzsTaJwDWwmNYqRstbf6c025cSkO7ihmo6EM8AhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Dj2GRfnC; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Dj2GRfnC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740997674; x=1772533674; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=0OdUdx+lahN2+LUJ2jOFDFj83SCLzyn+8zKWv0oeisM=; b=Dj2GRfnCeeeE26xX1U1wVgGcxbgOOr5njzphXXzuU+j0heMcGLOn8P5W oUae36lcR2jacvkquv63xFOjwX1a8D6XDeY7T6eo10hoy387pwOD9g2Sk rRt4I6ndHGe8A2HABxfz16CqADrCGEeoQx9owUjfI5RrP8DtKKJ1+TyGC 30B/TtANmJQE8LYjKG/RURb3WcSEgo5j7khlMFgIkiw/8Igv2XoYjS9oz AxDUwh1Ix/7TlPReLvtajY79APjpXiMt0xNI2GCzdbS49x6VVrkj9Sl3i bdE32y9eOycIKY3dJhrCckB294MdvSWIL00cQXfHJak1e0dpyzw3pS6+Z A==; X-CSE-ConnectionGUID: 8qM/HRWRTImO+ZHEP9WyJg== X-CSE-MsgGUID: EKhIwHZYRt6zxbPmW6PU6w== X-IronPort-AV: E=McAfee;i="6700,10204,11361"; a="64310126" X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="64310126" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 02:27:53 -0800 X-CSE-ConnectionGUID: bzzqNQ9KRwmBcBOF9J3FRA== X-CSE-MsgGUID: +JhLkkIHRPitcZla1/YuwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="122569877" Received: from mohdfai2-ilbpg12-1.png.intel.com ([10.88.227.73]) by fmviesa005.fm.intel.com with ESMTP; 03 Mar 2025 02:27:46 -0800 From: Faizal Rahim To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Furong Xu <0x1207@gmail.com>, Russell King , Vladimir Oltean , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Andrew Halaney , Choong Yong Liang , Faizal Rahim , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: [PATCH iwl-next v7 3/9] igc: Optimize the TX packet buffer utilization Date: Mon, 3 Mar 2025 05:26:52 -0500 Message-Id: <20250303102658.3580232-4-faizal.abdul.rahim@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250303102658.3580232-1-faizal.abdul.rahim@linux.intel.com> References: <20250303102658.3580232-1-faizal.abdul.rahim@linux.intel.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Packet buffers (RX + TX) total 64KB. Neither RX or TX buffers can be larger than 34KB. So divide the buffer equally, 32KB for each. Co-developed-by: Vinicius Costa Gomes Signed-off-by: Vinicius Costa Gomes Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc_defines.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h index 8e449904aa7d..516ef70c98e9 100644 --- a/drivers/net/ethernet/intel/igc/igc_defines.h +++ b/drivers/net/ethernet/intel/igc/igc_defines.h @@ -400,7 +400,8 @@ #define I225_TXPBSIZE_DEFAULT 0x04000014 /* TXPBSIZE default */ #define IGC_RXPBS_CFG_TS_EN 0x80000000 /* Timestamp in Rx buffer */ -#define IGC_TXPBSIZE_TSN 0x04145145 /* 5k bytes buffer for each queue */ + /* 7KB bytes buffer for each tx queue (total 4 queues) + 4KB for BMC*/ +#define IGC_TXPBSIZE_TSN 0x041c71c7 #define IGC_DTXMXPKTSZ_TSN 0x19 /* 1600 bytes of max TX DMA packet size */ #define IGC_DTXMXPKTSZ_DEFAULT 0x98 /* 9728-byte Jumbo frames */ -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA35DC282C6 for ; Mon, 3 Mar 2025 10:27:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 54DBA4096F; Mon, 3 Mar 2025 10:27:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nk-mLruCp3Za; Mon, 3 Mar 2025 10:27:56 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8F8E5409E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1740997676; bh=L663zWHJAJ0zSwFRe0E4kjWKNAWHc7L/2kdkPLFx/qk=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K+H2GnyIjAXCnahj0SImI9akm78XaqER2U36yNE0C31yMeb4UdEa94GOLR0TwPxw4 69gbzPYrwcdWeCDQtKeRIl+SBq5nGFcrNdl+1YrAZDt0GKcIpNAlksf27ySPwxOdDy QyIWliWhzBIfFm4Wz0u23i46zHniRoGkP6UbEz9qFRxutirVkFko6MHTDXJgla44ts dA6vBZ2ryO38W+fMz5h+Hvnva4IXEMhV+auayjeW8sT/nTT6pd7/xdip4+IEXtHmcm YTfai3YrOGUX2z7ntvJwqzr+lCs/6Aprv+k1SOJbqny999FvbvfNxZiN4Gvr1fDpOe k7ahw+KD7x4OQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 8F8E5409E5; Mon, 3 Mar 2025 10:27:56 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists1.osuosl.org (Postfix) with ESMTP id 872CBC1 for ; Mon, 3 Mar 2025 10:27:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 73434409E5 for ; Mon, 3 Mar 2025 10:27:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6l9NINvg_JNO for ; Mon, 3 Mar 2025 10:27:53 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=198.175.65.9; helo=mgamail.intel.com; envelope-from=faizal.abdul.rahim@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 8672C40958 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8672C40958 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by smtp4.osuosl.org (Postfix) with ESMTPS id 8672C40958 for ; Mon, 3 Mar 2025 10:27:53 +0000 (UTC) X-CSE-ConnectionGUID: uBKs+wTqSO6WDjsFWyrI7g== X-CSE-MsgGUID: 4HVMq53/RlOsPWQXua/iCQ== X-IronPort-AV: E=McAfee;i="6700,10204,11361"; a="64310122" X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="64310122" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2025 02:27:53 -0800 X-CSE-ConnectionGUID: bzzqNQ9KRwmBcBOF9J3FRA== X-CSE-MsgGUID: +JhLkkIHRPitcZla1/YuwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,329,1732608000"; d="scan'208";a="122569877" Received: from mohdfai2-ilbpg12-1.png.intel.com ([10.88.227.73]) by fmviesa005.fm.intel.com with ESMTP; 03 Mar 2025 02:27:46 -0800 From: Faizal Rahim To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Furong Xu <0x1207@gmail.com>, Russell King , Vladimir Oltean , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Andrew Halaney , Choong Yong Liang , Faizal Rahim , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Date: Mon, 3 Mar 2025 05:26:52 -0500 Message-Id: <20250303102658.3580232-4-faizal.abdul.rahim@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250303102658.3580232-1-faizal.abdul.rahim@linux.intel.com> References: <20250303102658.3580232-1-faizal.abdul.rahim@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740997674; x=1772533674; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=0OdUdx+lahN2+LUJ2jOFDFj83SCLzyn+8zKWv0oeisM=; b=Dj2GRfnCeeeE26xX1U1wVgGcxbgOOr5njzphXXzuU+j0heMcGLOn8P5W oUae36lcR2jacvkquv63xFOjwX1a8D6XDeY7T6eo10hoy387pwOD9g2Sk rRt4I6ndHGe8A2HABxfz16CqADrCGEeoQx9owUjfI5RrP8DtKKJ1+TyGC 30B/TtANmJQE8LYjKG/RURb3WcSEgo5j7khlMFgIkiw/8Igv2XoYjS9oz AxDUwh1Ix/7TlPReLvtajY79APjpXiMt0xNI2GCzdbS49x6VVrkj9Sl3i bdE32y9eOycIKY3dJhrCckB294MdvSWIL00cQXfHJak1e0dpyzw3pS6+Z A==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Dj2GRfnC Subject: [Intel-wired-lan] [PATCH iwl-next v7 3/9] igc: Optimize the TX packet buffer utilization X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Packet buffers (RX + TX) total 64KB. Neither RX or TX buffers can be larger than 34KB. So divide the buffer equally, 32KB for each. Co-developed-by: Vinicius Costa Gomes Signed-off-by: Vinicius Costa Gomes Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc_defines.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igc/igc_defines.h b/drivers/net/ethernet/intel/igc/igc_defines.h index 8e449904aa7d..516ef70c98e9 100644 --- a/drivers/net/ethernet/intel/igc/igc_defines.h +++ b/drivers/net/ethernet/intel/igc/igc_defines.h @@ -400,7 +400,8 @@ #define I225_TXPBSIZE_DEFAULT 0x04000014 /* TXPBSIZE default */ #define IGC_RXPBS_CFG_TS_EN 0x80000000 /* Timestamp in Rx buffer */ -#define IGC_TXPBSIZE_TSN 0x04145145 /* 5k bytes buffer for each queue */ + /* 7KB bytes buffer for each tx queue (total 4 queues) + 4KB for BMC*/ +#define IGC_TXPBSIZE_TSN 0x041c71c7 #define IGC_DTXMXPKTSZ_TSN 0x19 /* 1600 bytes of max TX DMA packet size */ #define IGC_DTXMXPKTSZ_DEFAULT 0x98 /* 9728-byte Jumbo frames */ -- 2.34.1