All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: axboe@kernel.dk, martin.petersen@oracle.com,
	anuj1072538@gmail.com, nikh1092@linux.ibm.com,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	linux-scsi@vger.kernel.org, dm-devel@lists.linux.dev,
	M Nikhil <nikhilm@linux.ibm.com>
Subject: Re: [PATCH v2 2/2] block: Correctly initialize BLK_INTEGRITY_NOGENERATE and BLK_INTEGRITY_NOVERIFY
Date: Mon, 3 Mar 2025 15:11:26 +0100	[thread overview]
Message-ID: <20250303141126.GA16268@lst.de> (raw)
In-Reply-To: <20250226112035.2571-3-anuj20.g@samsung.com>

On Wed, Feb 26, 2025 at 04:50:35PM +0530, Anuj Gupta wrote:
> Currently, BLK_INTEGRITY_NOGENERATE and BLK_INTEGRITY_NOVERIFY are not
> explicitly set during integrity initialization. This can lead to incorrect
> reporting of read_verify and write_generate sysfs values, particularly when
> a device does not support integrity. This patch ensures that these flags
> are correctly initialized by default.

You don't need to stay "this patch" in a commit log, just state what
it is doing.  Also please wrap commit log lines at 73 characters.

The code changes themselves here look good.


      reply	other threads:[~2025-03-03 14:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250226112855epcas5p330a1f2e300a44ddea5189ff906de7788@epcas5p3.samsung.com>
2025-02-26 11:20 ` [PATCH v2 0/2] Fix integrity sysfs reporting inconsistencies Anuj Gupta
2025-02-26 11:20   ` [PATCH v2 1/2] block: ensure correct integrity capability propagation in stacked devices Anuj Gupta
2025-03-03 14:12     ` Christoph Hellwig
2025-03-04  8:48       ` Anuj Gupta
2025-03-04 13:55         ` Christoph Hellwig
2025-02-26 11:20   ` [PATCH v2 2/2] block: Correctly initialize BLK_INTEGRITY_NOGENERATE and BLK_INTEGRITY_NOVERIFY Anuj Gupta
2025-03-03 14:11     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250303141126.GA16268@lst.de \
    --to=hch@lst.de \
    --cc=anuj1072538@gmail.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nikh1092@linux.ibm.com \
    --cc=nikhilm@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.