From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Simon Horman <horms@kernel.org>, Joe Damato <jdamato@fastly.com>,
Tariq Toukan <tariqt@nvidia.com>,
ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next] net: ethtool: Don't check if RSS context exists in case of context 0
Date: Mon, 3 Mar 2025 14:17:17 -0800 [thread overview]
Message-ID: <20250303141717.67f6d417@kernel.org> (raw)
In-Reply-To: <f5bf9ab4-bc65-45fe-804d-9c84d8b7bf1f@nvidia.com>
On Sun, 2 Mar 2025 11:55:34 +0200 Gal Pressman wrote:
> >> I can think of something like redirecting all TCP traffic to context 1,
> >> and then a specific TCP 5-tuple to the default context.
> >
> > The ordering guarantees of ntuple filters are a bit unclear.
> > My understanding was that first match terminates the search,
> > actually, so your example wouldn't work :S
>
> The ordering should be done according to the rule location.
> * @location: Location of rule in the table. Locations must be
> * numbered such that a flow matching multiple rules will be
> * classified according to the first (lowest numbered) rule.
I'm aware, Gal, but the question is whether every driver developer
is aware of this, not just me and perhaps you.
> The cited patch is a regression from user's perspective. Surely, not an
> intended one?
I believe this message should already answer you questions:
https://lore.kernel.org/all/20250226204503.77010912@kernel.org/
Fix the commit message, add test, repost.
next prev parent reply other threads:[~2025-03-03 22:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 7:13 [PATCH net-next] net: ethtool: Don't check if RSS context exists in case of context 0 Gal Pressman
2025-02-25 16:35 ` Joe Damato
2025-02-26 1:01 ` Jakub Kicinski
2025-02-26 6:08 ` Gal Pressman
2025-02-27 2:27 ` Jakub Kicinski
2025-02-27 4:45 ` Jakub Kicinski
2025-02-27 15:18 ` Edward Cree
2025-02-27 15:29 ` Jakub Kicinski
2025-02-27 16:24 ` Edward Cree
2025-02-27 16:56 ` Jakub Kicinski
2025-02-27 19:54 ` Edward Cree
2025-03-02 9:55 ` Gal Pressman
2025-03-03 22:17 ` Jakub Kicinski [this message]
2025-03-04 11:09 ` Gal Pressman
2025-03-04 11:27 ` Gal Pressman
2025-02-26 17:42 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303141717.67f6d417@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.