From: Jakub Kicinski <kuba@kernel.org>
To: andrew@lunn.ch
Cc: Gerhard Engleder <gerhard@engleder-embedded.com>,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v9 2/8] net: phy: Support speed selection for PHY loopback
Date: Mon, 3 Mar 2025 17:35:00 -0800 [thread overview]
Message-ID: <20250303173500.431b298e@kernel.org> (raw)
In-Reply-To: <20250227203138.60420-3-gerhard@engleder-embedded.com>
On Thu, 27 Feb 2025 21:31:32 +0100 Gerhard Engleder wrote:
> phy_loopback() leaves it to the PHY driver to select the speed of the
> loopback mode. Thus, the speed of the loopback mode depends on the PHY
> driver in use.
>
> Add support for speed selection to phy_loopback() to enable loopback
> with defined speeds. Ensure that link up is signaled if speed changes
> as speed is not allowed to change during link up. Link down and up is
> necessary for a new speed.
Hi Andrew, does this one look good to you? I see your review tags
on other patches :)
next prev parent reply other threads:[~2025-03-04 1:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 20:31 [PATCH net-next v9 0/8] Support loopback mode speed selection Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 1/8] net: phy: Allow loopback speed selection for PHY drivers Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 2/8] net: phy: Support speed selection for PHY loopback Gerhard Engleder
2025-03-04 1:35 ` Jakub Kicinski [this message]
2025-03-04 13:20 ` Andrew Lunn
2025-03-04 16:15 ` Jakub Kicinski
2025-03-04 20:00 ` Gerhard Engleder
2025-03-06 5:58 ` Gerhard Engleder
2025-03-07 16:27 ` Andrew Lunn
2025-03-07 19:15 ` Gerhard Engleder
2025-03-11 5:39 ` Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 3/8] net: phy: micrel: Add loopback support Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 4/8] net: phy: marvell: Align set_loopback() implementation Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 5/8] tsnep: Select speed for loopback Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 6/8] net: selftests: Support selftest sets Gerhard Engleder
2025-03-04 1:41 ` Jakub Kicinski
2025-03-04 5:55 ` Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 7/8] net: selftests: Add selftests sets with fixed speed Gerhard Engleder
2025-02-27 20:31 ` [PATCH net-next v9 8/8] tsnep: Add loopback selftests Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303173500.431b298e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.