From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mika Westerberg <westeri@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kent Gibson <warthog618@gmail.com>
Subject: Re: [PATCH v1 2/3] gpiolib: Rename gpio_set_debounce_timeout() to gpiod_do_set_debounce()
Date: Tue, 4 Mar 2025 11:18:04 +0200 [thread overview]
Message-ID: <20250304091804.GG3713119@black.fi.intel.com> (raw)
In-Reply-To: <20250303160341.1322640-3-andriy.shevchenko@linux.intel.com>
On Mon, Mar 03, 2025 at 06:00:33PM +0200, Andy Shevchenko wrote:
> In order to reduce the 'gpio' namespace when operate over GPIO descriptor
> rename gpio_set_debounce_timeout() to gpiod_do_set_debounce().
To me anything that has '_do_' in their name sounds like an internal static
function that gets wrapped by the actual API function(s).
For instance it could be
int gpio_set_debounce_timeout()
{
...
gpiod_do_set_debounce()
...
However, gpiod_set_debounce_timeout() or gpiod_set_debounce() sounds good
to me.
next prev parent reply other threads:[~2025-03-04 9:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 16:00 [PATCH v1 0/3] gpiolib: Reduce 'gpio' namespace when operate over GPIOd Andy Shevchenko
2025-03-03 16:00 ` [PATCH v1 1/3] gpiolib: Align FLAG_* definitions in the struct gpio_desc Andy Shevchenko
2025-03-04 8:44 ` Linus Walleij
2025-03-03 16:00 ` [PATCH v1 2/3] gpiolib: Rename gpio_set_debounce_timeout() to gpiod_do_set_debounce() Andy Shevchenko
2025-03-04 8:44 ` Linus Walleij
2025-03-04 9:18 ` Mika Westerberg [this message]
2025-03-04 10:59 ` Andy Shevchenko
2025-03-04 11:11 ` Mika Westerberg
2025-03-04 11:16 ` Andy Shevchenko
2025-03-04 11:31 ` Mika Westerberg
2025-03-04 12:00 ` Andy Shevchenko
2025-03-04 12:15 ` Bartosz Golaszewski
2025-03-04 13:38 ` Andy Shevchenko
2025-03-04 13:43 ` Bartosz Golaszewski
2025-03-03 16:00 ` [PATCH v1 3/3] gpiolib: Rename gpio_do_set_config() --> gpiod_do_set_config() Andy Shevchenko
2025-03-03 16:09 ` Andy Shevchenko
2025-03-03 16:10 ` Andy Shevchenko
2025-03-04 8:45 ` Linus Walleij
2025-03-04 13:41 ` (subset) [PATCH v1 0/3] gpiolib: Reduce 'gpio' namespace when operate over GPIOd Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304091804.GG3713119@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=warthog618@gmail.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.