From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH net-next v2 2/8] netconsole: Make boolean comparison consistent
Date: Tue, 4 Mar 2025 11:50:23 +0000 [thread overview]
Message-ID: <20250304115023.GB3666230@kernel.org> (raw)
In-Reply-To: <20250228-netcons_current-v2-2-f53ff79a0db2@debian.org>
On Fri, Feb 28, 2025 at 04:50:18AM -0800, Breno Leitao wrote:
> Convert the current state assignment to use explicit boolean conversion,
> making the code more robust and easier to read. This change adds a
> double-negation operator to ensure consistent boolean conversion as
> suggested by Paolo[1].
>
> This approach aligns with the existing pattern used in
> sysdata_cpu_nr_enabled_show().
>
> Link: https://lore.kernel.org/all/7309e760-63b0-4b58-ad33-2fb8db361141@redhat.com/ [1]
> Signed-off-by: Breno Leitao <leitao@debian.org>
Thanks Breno,
FWIIW, I 100% agree with this change.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-03-04 11:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 12:50 [PATCH net-next v2 0/8] netconsole: Add taskname sysdata support Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 1/8] netconsole: prefix CPU_NR sysdata feature with SYSDATA_ Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 2/8] netconsole: Make boolean comparison consistent Breno Leitao
2025-03-04 11:50 ` Simon Horman [this message]
2025-02-28 12:50 ` [PATCH net-next v2 3/8] netconsole: refactor CPU number formatting into separate function Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 4/8] netconsole: add taskname to extradata entry count Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 5/8] netconsole: add configfs controls for taskname sysdata feature Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 6/8] netconsole: add task name to extra data fields Breno Leitao
2025-03-04 11:52 ` Simon Horman
2025-02-28 12:50 ` [PATCH net-next v2 7/8] netconsole: docs: document the task name feature Breno Leitao
2025-02-28 12:50 ` [PATCH net-next v2 8/8] netconsole: selftest: add task name append testing Breno Leitao
2025-03-04 14:50 ` [PATCH net-next v2 0/8] netconsole: Add taskname sysdata support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304115023.GB3666230@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.