All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <kw@linux.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: Fix typos
Date: Wed, 5 Mar 2025 01:31:05 +0900	[thread overview]
Message-ID: <20250304163105.GD2310180@rocinante> (raw)
In-Reply-To: <20250304162014.GA227956@bhelgaas>

Hello,

[...]
> > > Fix typos and whitespace errors.
> > 
> > Oh nice!  Thank you for doing this!
> > 
> > While we are at this...  I wonder if we could also see about some things
> > that I often see in the code, too.  For example:
> > 
> >   - "pci" or "pcie" instead of "PCI" and "PCIe"
> >   - "PCIE", PCI-E" or "PCI-Express" over "PCIe" and "PCI Express", etc.
> >   - "aer" over "AER"
> >   - "translateable" over "translatable"
> >   - "SPCIFIC" over "SPECIFIC"
> >   - "OVERIDE" over "OVERRIDE"
> >   - "Root port" or "Root complex" over "Root Port", etc.
> >   - "dbi" over "DBI"
> >   - "requestor" vs "requester"
> >   - "fom" over "from"
> >   - "reserv" over "reserved"
> > 
> > Would be nice to get these also fixed up nicely since we are already
> > cleaning things up.
> 
> Locally fixed these:
> 
>   translateable -> translatable
>   SPCIFIC -> SPECIFIC
>   OVERIDE -> OVERRIDE
>   fom -> from

Thank you!

There are also some potentially awkward and/or not correctly formatted
comments in few places, per:

  drivers/pci/xen-pcifront.c
  641:	/*in case of we lost an aer request in four lines time_window*/
  642-	smp_mb__before_atomic();
  --
  702:	/*Flag for registering PV AER handler*/
  703-	set_bit(_XEN_PCIB_AERHANDLER, (void *)&pdev->sh_info->flags);
  
  drivers/pci/quirks.c
  3388:#endif /*CONFIG_MMC_RICOH_MMC*/
  3389-
  
  drivers/pci/hotplug/cpqphp_ctrl.c
  279:					/*FIXME
  280-					panic(msg_power_fault); */
  
  drivers/pci/hotplug/ibmphp_pci.c
  467:				/*_______________This is for debugging purposes only______________________________*/
  468-				debug("b4 writing, start address is %x\n", func->pfmem[count]->start);
  --
  471:				/*_________________________________________________________________________________*/
  472-
  --
  1053:	int howmany = 0;	/*this is to see if there are any devices behind the bridge */
  1054-
  
  drivers/pci/hotplug/cpqphp_core.c
  622:		/*FIXME: these capabilities aren't used but if they are
  623-		 *	 they need to be correctly implemented

This is something that always stands out to me when I am looking at this
code.  Not sure if we want to adjust these at some point or not.  Perhaps
now would also be a good time.

Thank you again!

	Krzysztof

  reply	other threads:[~2025-03-04 16:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 21:11 [PATCH] PCI: Fix typos Bjorn Helgaas
2025-03-04  8:57 ` Krzysztof Wilczyński
2025-03-04 16:20   ` Bjorn Helgaas
2025-03-04 16:31     ` Krzysztof Wilczyński [this message]
2025-03-04 16:01 ` Ilpo Järvinen
2025-03-04 16:58   ` Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2025-07-22 21:37 Bjorn Helgaas
2025-07-23  7:07 ` Thomas Gleixner
2024-11-02 17:45 Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250304163105.GD2310180@rocinante \
    --to=kw@linux.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.