From: Jakub Kicinski <kuba@kernel.org>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/6] net/rds: Avoid queuing superfluous send and recv work
Date: Tue, 4 Mar 2025 16:44:12 -0800 [thread overview]
Message-ID: <20250304164412.24f4f23a@kernel.org> (raw)
In-Reply-To: <b3f771fbc3cb987cd2bd476b845fdd1f901c7730.camel@oracle.com>
On Wed, 5 Mar 2025 00:38:41 +0000 Allison Henderson wrote:
> > I'm guessing the comments were added because checkpatch asked for them.
> > The comments are supposed to indicate what this barrier pairs with.
> > I don't see the purpose of these barriers, please document..
>
> Hi Jakob,
>
> I think the comments meant to refer to the implicit memory barrier in
> "test_and_set_bit". It looks like it has assembly code to set the
> barrier if CONFIG_SMP is set. How about we change the comments to:
> "pairs with implicit memory barrier in test_and_set_bit()" ? Let me
> know what you think.
Okay, but what is the purpose. The commit message does not explain
at all why these barriers are needed.
next prev parent reply other threads:[~2025-03-05 0:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 4:26 [PATCH 0/6] RDS bug fix collection allison.henderson
2025-02-27 4:26 ` [PATCH 1/6] net/rds: Avoid queuing superfluous send and recv work allison.henderson
2025-03-01 0:19 ` Jakub Kicinski
2025-03-05 0:38 ` Allison Henderson
2025-03-05 0:44 ` Jakub Kicinski [this message]
2025-03-06 16:41 ` Allison Henderson
2025-03-06 18:18 ` Jakub Kicinski
2025-03-07 20:28 ` Allison Henderson
2025-03-08 2:53 ` Jakub Kicinski
2025-03-12 7:50 ` Allison Henderson
2025-03-26 16:42 ` Jakub Kicinski
2025-04-02 1:34 ` Allison Henderson
2025-04-02 16:18 ` Jakub Kicinski
2025-04-03 1:27 ` Allison Henderson
2025-02-27 4:26 ` [PATCH 2/6] net/rds: Re-factor and avoid superfluous queuing of reconnect work allison.henderson
2025-02-27 4:26 ` [PATCH 3/6] net/rds: RDS/TCP does not initiate a connection allison.henderson
2025-02-27 4:26 ` [PATCH 4/6] net/rds: No shortcut out of RDS_CONN_ERROR allison.henderson
2025-03-01 0:19 ` Jakub Kicinski
2025-03-05 0:38 ` Allison Henderson
2025-02-27 4:26 ` [PATCH 5/6] net/rds: rds_tcp_accept_one ought to not discard messages allison.henderson
2025-03-01 0:21 ` Jakub Kicinski
2025-03-06 16:41 ` Allison Henderson
2025-03-01 23:22 ` kernel test robot
2025-03-05 0:43 ` Allison Henderson
2025-03-04 10:28 ` Dan Carpenter
2025-03-05 0:39 ` Allison Henderson
2025-02-27 4:26 ` [PATCH 6/6] net/rds: Encode cp_index in TCP source port allison.henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304164412.24f4f23a@kernel.org \
--to=kuba@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.