From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EF8AC021B8 for ; Tue, 4 Mar 2025 17:30:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 77073818A7; Tue, 4 Mar 2025 17:30:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 6p21XoYqtO_g; Tue, 4 Mar 2025 17:30:28 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C9A9E81453 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1741109428; bh=4XZ83idWzI9RFRBdvxHmTuPOrheXC7/d1oOEtcKE2fU=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=75aBgclLzpGHZ7qSjQ6o+VtyvWBfUHDEJ8YBA7HcB5D43JpC+ArfEqOkhEPWCMxeN 6Zp4EOADd46/O23mp1ktHlnAM2QDscQoTXy66hZzRpz5Re7JSHRhBpA6iZ/0nvzIRC YwQkosESzuDdkUulLCtOTNWrB9lhqWY1EcHDH55iL+L3PgysERsGbSN5EdsNm94DI8 pV9SoozqQNnQRuuVu5tuwTYOXuZCIx8jXj1NbLOYHNv7i4gDgVbzRl++pQTCFM3ImZ aTcQMK3O71kVl8OaSQTXWTPYHZmnTsQ2xce4TsZbWb+sFQFmT7SyFPwjaZ4gTa2gVI 52MEgJE0gisDA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp1.osuosl.org (Postfix) with ESMTP id C9A9E81453; Tue, 4 Mar 2025 17:30:28 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 3A571941 for ; Tue, 4 Mar 2025 17:30:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1F0C060ABE for ; Tue, 4 Mar 2025 17:30:28 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2GtCKa4Q7h-q for ; Tue, 4 Mar 2025 17:30:27 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6FD8E607CE DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6FD8E607CE Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6FD8E607CE for ; Tue, 4 Mar 2025 17:30:27 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 58978A45A9B; Tue, 4 Mar 2025 17:24:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84BA8C4CEE5; Tue, 4 Mar 2025 17:30:23 +0000 (UTC) Date: Tue, 4 Mar 2025 17:30:21 +0000 From: Simon Horman To: Kurt Kanzenbach Cc: Tony Nguyen , Przemek Kitszel , Faizal Rahim , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Message-ID: <20250304173021.GH3666230@kernel.org> References: <20250303-igc_mqprio_tx_mode-v3-1-0efce85e6ae0@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303-igc_mqprio_tx_mode-v3-1-0efce85e6ae0@linutronix.de> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741109425; bh=xuCB2v1oTiS5aN88F+t/9IxGezhQ8OSGjVyYYhNHj48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hA5A/kjpuNwBuwkBfBPzGm3c4k3T/6X2O42kzkDgPM2PQPURnd4VrfbdjGinzSe4R 7Earfx7KtvrVS18Y89YQ1cKi63QqWQfJFiDazGcTh2Z2e/0O1M5pbTkoXGjheQeZbT E3n0D8ZgEJgjrRzLIPa/rpi9ac3UJsaiINh8HCMepERMI6BuUr0L0F2UV8rWlj6e79 f5+rQ+1Jx1qLnMGQ+66e63rlXkF2KcrZuIXeppiz8sWlrE6iIO4ql1Yb/O+3j3wiqj pik0zlBL1U/vRlK8BBkZT9MNphx5hh3nJpOcfZrakObklpaP2RJxc0W9BtlSKByAIh W3Z/3ygTR/GJQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hA5A/kjp Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Mar 03, 2025 at 10:16:33AM +0100, Kurt Kanzenbach wrote: > The current MQPRIO offload implementation uses the legacy TSN Tx mode. In > this mode the hardware uses four packet buffers and considers queue > priorities. > > In order to harmonize the TAPRIO implementation with MQPRIO, switch to the > regular TSN Tx mode. This mode also uses four packet buffers and considers > queue priorities. In addition to the legacy mode, transmission is always > coupled to Qbv. The driver already has mechanisms to use a dummy schedule > of 1 second with all gates open for ETF. Simply use this for MQPRIO too. > > This reduces code and makes it easier to add support for frame preemption > later. > > While at it limit the netdev_tc calls to MQPRIO only. Hi Kurt, Can this part be broken out into a separate patch? It seems so to me, but perhaps I'm missing something. The reason that I ask is that this appears to be a good portion of the change, and doing so would make the code changes for main part of the patch, as per the description prior to the line above, clearer IMHO. > > Tested on i225 with real time application using high priority queue, iperf3 > using low priority queue and network TAP device. > > Signed-off-by: Kurt Kanzenbach ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 773C028629C for ; Tue, 4 Mar 2025 17:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741109426; cv=none; b=MHYIF2zRUgS0lvjOIOjHoY1QQI1Brx5CInQh118aKo5VGME5TNVhHAYs7BR65KIzYrHIeKq5OsBc6JcNXi5wUNxBQJQbT92bK8E/F3CziTetRJf8sBLoPRD8yNODLWcPVO9zZ4xXDX8bqw4IttjUcK7pt9qcBy96WCgfh/5EiYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741109426; c=relaxed/simple; bh=xuCB2v1oTiS5aN88F+t/9IxGezhQ8OSGjVyYYhNHj48=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q3JiVdyLEFovSpGEp3jscS7OLBEz89xCT9v/RsBuHyP2fZciyUCO3xGcAuZcG1dm0hN1HSMAzmhwYWEN8ivPkMu8hCgtAxS7Iy9HOT3mca+0OIZLblUZMwNiVoUYgp8B5dxNGZVB0DgK0aQ3qGcCfEWvbIFB2hSwwt9FWyacQHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hA5A/kjp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hA5A/kjp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84BA8C4CEE5; Tue, 4 Mar 2025 17:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741109425; bh=xuCB2v1oTiS5aN88F+t/9IxGezhQ8OSGjVyYYhNHj48=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hA5A/kjpuNwBuwkBfBPzGm3c4k3T/6X2O42kzkDgPM2PQPURnd4VrfbdjGinzSe4R 7Earfx7KtvrVS18Y89YQ1cKi63QqWQfJFiDazGcTh2Z2e/0O1M5pbTkoXGjheQeZbT E3n0D8ZgEJgjrRzLIPa/rpi9ac3UJsaiINh8HCMepERMI6BuUr0L0F2UV8rWlj6e79 f5+rQ+1Jx1qLnMGQ+66e63rlXkF2KcrZuIXeppiz8sWlrE6iIO4ql1Yb/O+3j3wiqj pik0zlBL1U/vRlK8BBkZT9MNphx5hh3nJpOcfZrakObklpaP2RJxc0W9BtlSKByAIh W3Z/3ygTR/GJQ== Date: Tue, 4 Mar 2025 17:30:21 +0000 From: Simon Horman To: Kurt Kanzenbach Cc: Tony Nguyen , Przemek Kitszel , Faizal Rahim , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading Message-ID: <20250304173021.GH3666230@kernel.org> References: <20250303-igc_mqprio_tx_mode-v3-1-0efce85e6ae0@linutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250303-igc_mqprio_tx_mode-v3-1-0efce85e6ae0@linutronix.de> On Mon, Mar 03, 2025 at 10:16:33AM +0100, Kurt Kanzenbach wrote: > The current MQPRIO offload implementation uses the legacy TSN Tx mode. In > this mode the hardware uses four packet buffers and considers queue > priorities. > > In order to harmonize the TAPRIO implementation with MQPRIO, switch to the > regular TSN Tx mode. This mode also uses four packet buffers and considers > queue priorities. In addition to the legacy mode, transmission is always > coupled to Qbv. The driver already has mechanisms to use a dummy schedule > of 1 second with all gates open for ETF. Simply use this for MQPRIO too. > > This reduces code and makes it easier to add support for frame preemption > later. > > While at it limit the netdev_tc calls to MQPRIO only. Hi Kurt, Can this part be broken out into a separate patch? It seems so to me, but perhaps I'm missing something. The reason that I ask is that this appears to be a good portion of the change, and doing so would make the code changes for main part of the patch, as per the description prior to the line above, clearer IMHO. > > Tested on i225 with real time application using high priority queue, iperf3 > using low priority queue and network TAP device. > > Signed-off-by: Kurt Kanzenbach ...