From: David Arinzon <darinzon@amazon.com>
To: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>
Cc: David Arinzon <darinzon@amazon.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
"Richard Cochran" <richardcochran@gmail.com>,
"Woodhouse, David" <dwmw@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
Saeed Bshara <saeedb@amazon.com>, "Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Machnikowski, Maciek" <maciek@machnikowski.net>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: [PATCH v8 net-next 4/5] net: ena: PHC stats through sysfs
Date: Tue, 4 Mar 2025 21:05:03 +0200 [thread overview]
Message-ID: <20250304190504.3743-5-darinzon@amazon.com> (raw)
In-Reply-To: <20250304190504.3743-1-darinzon@amazon.com>
The patch allows retrieving PHC statistics
through sysfs.
In case the feature is not enabled (through `phc_enable`
sysfs entry), no output will be written.
Signed-off-by: David Arinzon <darinzon@amazon.com>
---
drivers/net/ethernet/amazon/ena/ena_sysfs.c | 80 +++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/drivers/net/ethernet/amazon/ena/ena_sysfs.c b/drivers/net/ethernet/amazon/ena/ena_sysfs.c
index d0ded92d..441085d2 100644
--- a/drivers/net/ethernet/amazon/ena/ena_sysfs.c
+++ b/drivers/net/ethernet/amazon/ena/ena_sysfs.c
@@ -65,6 +65,82 @@ static ssize_t ena_phc_enable_get(struct device *dev,
static DEVICE_ATTR(phc_enable, S_IRUGO | S_IWUSR, ena_phc_enable_get,
ena_phc_enable_set);
+/* Takes into account max u64 value, null and new line characters */
+#define ENA_PHC_STAT_MAX_LEN 22
+
+static ssize_t ena_phc_cnt_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct ena_adapter *adapter = dev_get_drvdata(dev);
+
+ if (!ena_phc_is_active(adapter))
+ return 0;
+
+ return snprintf(buf, ENA_PHC_STAT_MAX_LEN, "%llu\n",
+ adapter->ena_dev->phc.stats.phc_cnt);
+}
+
+static DEVICE_ATTR(phc_cnt, S_IRUGO, ena_phc_cnt_show, NULL);
+
+static ssize_t ena_phc_exp_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct ena_adapter *adapter = dev_get_drvdata(dev);
+
+ if (!ena_phc_is_active(adapter))
+ return 0;
+
+ return snprintf(buf, ENA_PHC_STAT_MAX_LEN, "%llu\n",
+ adapter->ena_dev->phc.stats.phc_exp);
+}
+
+static DEVICE_ATTR(phc_exp, S_IRUGO, ena_phc_exp_show, NULL);
+
+static ssize_t ena_phc_skp_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct ena_adapter *adapter = dev_get_drvdata(dev);
+
+ if (!ena_phc_is_active(adapter))
+ return 0;
+
+ return snprintf(buf, ENA_PHC_STAT_MAX_LEN, "%llu\n",
+ adapter->ena_dev->phc.stats.phc_skp);
+}
+
+static DEVICE_ATTR(phc_skp, S_IRUGO, ena_phc_skp_show, NULL);
+
+static ssize_t ena_phc_err_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
+{
+ struct ena_adapter *adapter = dev_get_drvdata(dev);
+
+ if (!ena_phc_is_active(adapter))
+ return 0;
+
+ return snprintf(buf, ENA_PHC_STAT_MAX_LEN, "%llu\n",
+ adapter->ena_dev->phc.stats.phc_err);
+}
+
+static DEVICE_ATTR(phc_err, S_IRUGO, ena_phc_err_show, NULL);
+
+static struct attribute *phc_stats_attrs[] = {
+ &dev_attr_phc_cnt.attr,
+ &dev_attr_phc_exp.attr,
+ &dev_attr_phc_skp.attr,
+ &dev_attr_phc_err.attr,
+ NULL
+};
+
+static struct attribute_group phc_stats_group = {
+ .attrs = phc_stats_attrs,
+ .name = "phc_stats",
+};
+
/******************************************************************************
*****************************************************************************/
int ena_sysfs_init(struct device *dev)
@@ -72,6 +148,9 @@ int ena_sysfs_init(struct device *dev)
if (device_create_file(dev, &dev_attr_phc_enable))
dev_err(dev, "Failed to create phc_enable sysfs entry");
+ if (device_add_group(dev, &phc_stats_group))
+ dev_err(dev, "Failed to create phc_stats sysfs group");
+
return 0;
}
@@ -80,4 +159,5 @@ int ena_sysfs_init(struct device *dev)
void ena_sysfs_terminate(struct device *dev)
{
device_remove_file(dev, &dev_attr_phc_enable);
+ device_remove_group(dev, &phc_stats_group);
}
--
2.47.1
next prev parent reply other threads:[~2025-03-04 19:05 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 19:04 [PATCH v8 net-next 0/5] PHC support in ENA driver David Arinzon
2025-03-04 19:05 ` [PATCH v8 net-next 1/5] net: ena: Add PHC support in the " David Arinzon
2025-03-04 19:05 ` [PATCH v8 net-next 2/5] net: ena: PHC silent reset David Arinzon
2025-03-04 19:05 ` [PATCH v8 net-next 3/5] net: ena: PHC enable through sysfs David Arinzon
2025-03-04 19:05 ` David Arinzon [this message]
2025-03-04 21:07 ` [PATCH v8 net-next 4/5] net: ena: PHC stats " Andrew Lunn
2025-03-04 22:58 ` Jakub Kicinski
2025-03-05 15:33 ` Andrew Lunn
2025-03-06 2:36 ` Jakub Kicinski
2025-03-06 7:15 ` Leon Romanovsky
2025-03-06 15:40 ` Andrew Lunn
2025-03-06 17:31 ` Leon Romanovsky
2025-03-26 15:39 ` Arinzon, David
2025-03-04 19:05 ` [PATCH v8 net-next 5/5] net: ena: Add PHC documentation David Arinzon
2025-03-04 21:10 ` Andrew Lunn
2025-03-05 12:50 ` Arinzon, David
2025-03-05 12:59 ` [EXTERNAL] " David Woodhouse
2025-03-05 15:35 ` Andrew Lunn
2025-03-05 17:52 ` Leon Romanovsky
2025-03-26 15:32 ` Arinzon, David
2025-03-27 11:15 ` Leon Romanovsky
2025-03-27 12:01 ` David Woodhouse
2025-04-01 8:02 ` David Woodhouse
2025-04-01 8:46 ` David Woodhouse
2025-04-02 16:23 ` Jakub Kicinski
2025-04-02 19:38 ` Leon Romanovsky
2025-04-07 7:01 ` Arinzon, David
2025-04-07 14:02 ` Andrew Lunn
2025-04-07 16:27 ` Jakub Kicinski
2025-04-08 14:47 ` Richard Cochran
2025-04-08 15:24 ` Jakub Kicinski
2025-04-10 4:07 ` Richard Cochran
2025-04-10 16:01 ` Jakub Kicinski
2025-03-04 23:00 ` [PATCH v8 net-next 0/5] PHC support in ENA driver Jakub Kicinski
2025-03-05 6:34 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304190504.3743-5-darinzon@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=edumazet@google.com \
--cc=evgenys@amazon.com \
--cc=evostrov@amazon.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=maciek@machnikowski.net \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=vadim.fedorenko@linux.dev \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.