All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH 1/5] lib/crc: remove unnecessary prompt for CONFIG_CRC4
Date: Tue,  4 Mar 2025 15:07:08 -0800	[thread overview]
Message-ID: <20250304230712.167600-2-ebiggers@kernel.org> (raw)
In-Reply-To: <20250304230712.167600-1-ebiggers@kernel.org>

From: Eric Biggers <ebiggers@google.com>

All modules that need CONFIG_CRC4 already select it, so there is no need
to bother users about the option.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 arch/s390/configs/debug_defconfig | 1 -
 arch/s390/configs/defconfig       | 1 -
 lib/Kconfig                       | 7 +------
 3 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/s390/configs/debug_defconfig b/arch/s390/configs/debug_defconfig
index d6beec5292a00..c46781f8570c1 100644
--- a/arch/s390/configs/debug_defconfig
+++ b/arch/s390/configs/debug_defconfig
@@ -813,11 +813,10 @@ CONFIG_CRYPTO_PAES_S390=m
 CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC4=m
 CONFIG_CRC7=m
 CONFIG_CRC8=m
 CONFIG_RANDOM32_SELFTEST=y
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y
diff --git a/arch/s390/configs/defconfig b/arch/s390/configs/defconfig
index 8cfbfb10bba8c..23d8bce642aa4 100644
--- a/arch/s390/configs/defconfig
+++ b/arch/s390/configs/defconfig
@@ -801,11 +801,10 @@ CONFIG_CRYPTO_DEV_VIRTIO=m
 CONFIG_SYSTEM_BLACKLIST_KEYRING=y
 CONFIG_CORDIC=m
 CONFIG_PRIME_NUMBERS=m
 CONFIG_CRYPTO_LIB_CURVE25519=m
 CONFIG_CRYPTO_LIB_CHACHA20POLY1305=m
-CONFIG_CRC4=m
 CONFIG_CRC7=m
 CONFIG_CRC8=m
 CONFIG_XZ_DEC_MICROLZMA=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=0
diff --git a/lib/Kconfig b/lib/Kconfig
index 67bbf4f64dd98..e867971c97669 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -207,16 +207,11 @@ config ARCH_HAS_CRC64
 config CRC64_ARCH
 	tristate
 	default CRC64 if ARCH_HAS_CRC64 && CRC_OPTIMIZATIONS
 
 config CRC4
-	tristate "CRC4 functions"
-	help
-	  This option is provided for the case where no in-kernel-tree
-	  modules require CRC4 functions, but a module built outside
-	  the kernel tree does. Such modules that use library CRC4
-	  functions require M here.
+	tristate
 
 config CRC7
 	tristate "CRC7 functions"
 	help
 	  This option is provided for the case where no in-kernel-tree
-- 
2.48.1


  reply	other threads:[~2025-03-04 23:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 23:07 [PATCH 0/5] Remove unnecessary prompts for CRC library (batch 1) Eric Biggers
2025-03-04 23:07 ` Eric Biggers [this message]
2025-03-04 23:07 ` [PATCH 2/5] lib/crc: remove unnecessary prompt for CONFIG_CRC7 Eric Biggers
2025-03-04 23:07 ` [PATCH 3/5] lib/crc: remove unnecessary prompt for CONFIG_CRC8 Eric Biggers
2025-03-04 23:07 ` [PATCH 4/5] lib/crc: remove unnecessary prompt for CONFIG_LIBCRC32C Eric Biggers
2025-03-04 23:07 ` [PATCH 5/5] lib/crc: remove unnecessary prompt for CONFIG_CRC64 Eric Biggers
2025-03-06  8:16 ` [PATCH 0/5] Remove unnecessary prompts for CRC library (batch 1) Ard Biesheuvel
2025-03-06 17:22 ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250304230712.167600-2-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=ardb@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.