From: Mateusz Guzik <mjguzik@gmail.com>
To: brauner@kernel.org
Cc: viro@zeniv.linux.org.uk, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Mateusz Guzik <mjguzik@gmail.com>
Subject: [PATCH v3 4/4] fs: use fput_close() in path_openat()
Date: Wed, 5 Mar 2025 13:36:44 +0100 [thread overview]
Message-ID: <20250305123644.554845-5-mjguzik@gmail.com> (raw)
In-Reply-To: <20250305123644.554845-1-mjguzik@gmail.com>
This bumps failing open rate by 1.7% on Sapphire Rapids by avoiding one
atomic.
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
fs/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/namei.c b/fs/namei.c
index d00443e38d3a..06765d320e7e 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -4005,7 +4005,7 @@ static struct file *path_openat(struct nameidata *nd,
WARN_ON(1);
error = -EINVAL;
}
- fput(file);
+ fput_close(file);
if (error == -EOPENSTALE) {
if (flags & LOOKUP_RCU)
error = -ECHILD;
--
2.43.0
next prev parent reply other threads:[~2025-03-05 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 12:36 [RFC PATCH v3 0/4] avoid the extra atomic on a ref when closing a fd Mateusz Guzik
2025-03-05 12:36 ` [PATCH v3 1/4] file: add fput and file_ref_put routines optimized for use " Mateusz Guzik
2025-03-05 12:36 ` [PATCH v3 2/4] fs: use fput_close_sync() in close() Mateusz Guzik
2025-03-05 12:36 ` [PATCH v3 3/4] fs: use fput_close() in filp_close() Mateusz Guzik
2025-03-05 12:36 ` Mateusz Guzik [this message]
2025-03-05 17:31 ` [RFC PATCH v3 0/4] avoid the extra atomic on a ref when closing a fd Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305123644.554845-5-mjguzik@gmail.com \
--to=mjguzik@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.