All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: longli@linuxonhyperv.com
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	Konstantin Taranov <kotaranov@microsoft.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
	Long Li <longli@microsoft.com>
Subject: Re: [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu
Date: Wed, 5 Mar 2025 14:56:04 -0800	[thread overview]
Message-ID: <20250305145604.56855467@kernel.org> (raw)
In-Reply-To: <1741213360-14567-1-git-send-email-longli@linuxonhyperv.com>

On Wed,  5 Mar 2025 14:22:39 -0800 longli@linuxonhyperv.com wrote:
> +	netdev_hold(ndev, NULL, GFP_ATOMIC);

😅️

I asked you to use this API for the tracker functionality, obviously.
Please don't pass NULL in.

  parent reply	other threads:[~2025-03-05 22:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 22:22 [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu longli
2025-03-05 22:22 ` [patch rdma-next v4 2/2] RDMA/mana_ib: Handle net event for pointing to the current netdev longli
2025-03-05 22:56 ` Jakub Kicinski [this message]
2025-03-05 23:29   ` [EXTERNAL] Re: [patch rdma-next v4 1/2] net: mana: Change the function signature of mana_get_primary_netdev_rcu Long Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250305145604.56855467@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jgg@ziepe.ca \
    --cc=kotaranov@microsoft.com \
    --cc=leon@kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@linuxonhyperv.com \
    --cc=longli@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.