From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACBEF1FCCE0 for ; Wed, 5 Mar 2025 08:49:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741164593; cv=none; b=GmpzWC8t5SXgdnupEG3UbXjtrcj0p2+dJBBWJtlJDy00o82cdLMzItNeWjLBw9QNplvTllgPp1lsuC5OCE/duTI3NJf5XmBB9zsGF/1D/NB97WqNxg6z6JtZJi7BMw6TWKi+Y09Bx65X8RncWfRLmSFVYUtLEXqv2030c/g6oG0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741164593; c=relaxed/simple; bh=6AeGg2TJx+EOxKASa/6Z2pzSEdLM07OALRwSKgOOX+Q=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WWQAvm7DxiITnDNHH0jMx0H2tlXKZAmgky2+2cplqbErE4RtoY1jdWf1z0KOMiFbmyMWQBTaxkqrzafIeME0HRqyCgssMKk6HgWoEzr3+ZMUuJOylitQ0a8+Pubsns+dc3ruVXkNO9o7WMeujXw8knSHlnsiQGJG2J5ftHTV8z4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Z75jf2HTQz6L52J; Wed, 5 Mar 2025 16:45:42 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 192DB140A08; Wed, 5 Mar 2025 16:49:48 +0800 (CST) Received: from localhost (10.96.237.92) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 5 Mar 2025 09:49:45 +0100 Date: Wed, 5 Mar 2025 16:49:40 +0800 From: Jonathan Cameron To: Vinayak Holikatti CC: , , , , , , , , Subject: Re: [PATCH v3 2/3] hw/cxl: factor out calculation of sanitize duration from cmd_santize_overwrite Message-ID: <20250305164940.00004a70@huawei.com> In-Reply-To: <20250220052724.1256642-3-vinayak.kh@samsung.com> References: <20250220052724.1256642-1-vinayak.kh@samsung.com> <20250220052724.1256642-3-vinayak.kh@samsung.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To frapeml500008.china.huawei.com (7.182.85.71) On Thu, 20 Feb 2025 10:57:23 +0530 Vinayak Holikatti wrote: > Move the code of calculation of sanitize duration into function > for usability by other sanitize routines > > Estimate times based on: > https://pmem.io/documents/NVDIMM_DSM_Interface-V1.8.pdf > > Signed-off-by: Davidlohr Bueso > Signed-off-by: Vinayak Holikatti Hi. Authorship of this patch is confused. Should Davidlohr have a Co-developed-by tag? (I think those are used in qemu) If not should the From tag be set to Davidlohr? I'm going to post a series for potential merge without this fixed as I'd like some more review anyway, but good to clarify what is going on in this patch. Jonathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A238C19F32 for ; Wed, 5 Mar 2025 08:50:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tpkRz-0001iG-59; Wed, 05 Mar 2025 03:49:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpkRv-0001hx-Js for qemu-devel@nongnu.org; Wed, 05 Mar 2025 03:49:55 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tpkRs-0003Co-F2 for qemu-devel@nongnu.org; Wed, 05 Mar 2025 03:49:55 -0500 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Z75jf2HTQz6L52J; Wed, 5 Mar 2025 16:45:42 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 192DB140A08; Wed, 5 Mar 2025 16:49:48 +0800 (CST) Received: from localhost (10.96.237.92) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 5 Mar 2025 09:49:45 +0100 Date: Wed, 5 Mar 2025 16:49:40 +0800 To: Vinayak Holikatti CC: , , , , , , , , Subject: Re: [PATCH v3 2/3] hw/cxl: factor out calculation of sanitize duration from cmd_santize_overwrite Message-ID: <20250305164940.00004a70@huawei.com> In-Reply-To: <20250220052724.1256642-3-vinayak.kh@samsung.com> References: <20250220052724.1256642-1-vinayak.kh@samsung.com> <20250220052724.1256642-3-vinayak.kh@samsung.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.96.237.92] X-ClientProxiedBy: lhrpeml500003.china.huawei.com (7.191.162.67) To frapeml500008.china.huawei.com (7.182.85.71) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, 20 Feb 2025 10:57:23 +0530 Vinayak Holikatti wrote: > Move the code of calculation of sanitize duration into function > for usability by other sanitize routines > > Estimate times based on: > https://pmem.io/documents/NVDIMM_DSM_Interface-V1.8.pdf > > Signed-off-by: Davidlohr Bueso > Signed-off-by: Vinayak Holikatti Hi. Authorship of this patch is confused. Should Davidlohr have a Co-developed-by tag? (I think those are used in qemu) If not should the From tag be set to Davidlohr? I'm going to post a series for potential merge without this fixed as I'd like some more review anyway, but good to clarify what is going on in this patch. Jonathan